Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pattern Search #101

Closed
getsetbro opened this issue Feb 27, 2015 · 7 comments
Closed

Support Pattern Search #101

getsetbro opened this issue Feb 27, 2015 · 7 comments

Comments

@getsetbro
Copy link
Contributor

http://getsetbro.com/pl-nodeV8/public/

Page Follow and Auto Reload do not seem to do anything in the settings menu.

@bmuenzenmeyer
Copy link
Member

To be honest, I don't recall specifically investigating support for search during the port, which has been in dev for over a year and morphed as PL PHP has a bit.

I will investigate this as part of v1.0.0 (a contribution is welcome too 😄 ). I will be renaming this issue to "Support Pattern Search."

Page follow was investigated in #86 but navigation did not work as expected. This is something I'd like to get working at some point. I've opened an issue for this #103.

Live reload works oob with the grunt tasks when launched as grunt serve. This option should just be removed from PL Node as it doesn't really make sense. I've opened an issue for this: #102

@bmuenzenmeyer bmuenzenmeyer changed the title Has the search feature ever worked? Support Pattern Search Feb 28, 2015
@bmuenzenmeyer bmuenzenmeyer added this to the v1.0.0 milestone Feb 28, 2015
@bmuenzenmeyer
Copy link
Member

This is currently turned off by default in the navigation, but we should just get it working :)

@bmuenzenmeyer bmuenzenmeyer modified the milestones: v1.0.0, v0.8.2 Mar 10, 2015
bmuenzenmeyer added a commit that referenced this issue Mar 10, 2015
@bmuenzenmeyer
Copy link
Member

Hey @getsetbro this was just pushed to dev branch. If you could upgrade and verify functionality I would appreciate it. Otherwise I'll hammer on it a bit more too :)

@getsetbro
Copy link
Contributor Author

Boom. Roasted.

@christophrumpel
Copy link

Is the search functionality already in the current release? Can't find any information about it?

@bmuenzenmeyer
Copy link
Member

Hi @christophrumpel

you should see it on the current release on the top right of the style guide

image

It's behind the find flag in config.json https://github.com/pattern-lab/patternlab-node/blob/master/config.json

@christophrumpel
Copy link

Ah I see. Thanks. I thought there might be some info in the documentation on how it works or something similar. But I will try it now myself. Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants