Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BrowserSync #86

Merged
merged 3 commits into from
Jan 22, 2015
Merged

Added BrowserSync #86

merged 3 commits into from
Jan 22, 2015

Conversation

ivanmayes
Copy link
Contributor

Added browsersync to the Gruntfile, should automatically start up now. You can open the same url with different devices/browsers and it will sync your scrolling and auto refresh devices so that you can sync looking at your styles while working on them.

Currently Ios doesnt sync with scrolling, but it will auto refresh with the rest of the devices.

Because of the way the navigation works, it doesn't currently support syncing the moving between pages, there might be a way to solve this though.

I changed the 'connect' hostname to be your public wifi address so that your devices could access patternlab, but left the hostname line commented in if you want to opt out of having your styleguide available over Wifi.

Sorry about the messy Gruntfile commit, my javascript formatter on save reformatted a couple of things and made it messy.

bmuenzenmeyer pushed a commit that referenced this pull request Jan 22, 2015
@bmuenzenmeyer bmuenzenmeyer merged commit 5f8028b into pattern-lab:dev Jan 22, 2015
@bmuenzenmeyer
Copy link
Member

Hi @ivanmayes I started playing with this in dev tonight. There are some things I love, and some I'd like to hammer out more.

  • inject new/updated patterns
  • inject updated data.json
  • look into why scrolling is not working (Windows to Windows)
  • look into nav syncing

A great start though. Thanks for pushing this forward.

@bmuenzenmeyer
Copy link
Member

@bmuenzenmeyer
Copy link
Member

@ivanmayes I've played around with this - and will likely remove it if I cannot get navigation working. It's a pretty heavy dependency to include only to have it missing a large piece of functionality. Either way I will document usage of this and keep it on the roadmap for future consideration.

@ivanmayes
Copy link
Contributor Author

Understood. Super busy at work, but will keep my branch with it and mess around at some point to try to get the navigation working.

This was referenced Feb 28, 2015
bmuenzenmeyer pushed a commit that referenced this pull request Apr 17, 2020
Documentation / Reference updates & Handlebars vuln. fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants