Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update minifront bundled assets #5119

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Mar 5, 2025

Describe your changes

Built from head on web repo 68a1cd50391197ee180af9966e474e04363c50f8. Tested locally, and I see the new version displayed in my local browser, in the footer.

Issue ticket number and link

No specific issue, updating opportunistically. Towards #5118.

Testing and review

We don't have automated tests to ensure the version spec, so I already confirmed locally that the appropriate commit has is referenced. Therefore, as long as CI is green on this PR, we're good to go.

Checklist before requesting a review

  • I have added guiding text to explain how a reviewer should test these changes.

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    no changes to consensus logic, only updated a GUI frontend

@conorsch conorsch requested a review from cronokirby March 5, 2025 19:43
@conorsch conorsch mentioned this pull request Mar 5, 2025
3 tasks
@TalDerei TalDerei self-requested a review March 5, 2025 20:00
Copy link
Collaborator

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@conorsch
Copy link
Contributor Author

conorsch commented Mar 5, 2025

@TalDerei mentioned a possible additional commit that'd be nice to include, so pausing for a bit.

@conorsch conorsch marked this pull request as draft March 5, 2025 20:11
Built from head on web repo 68a1cd50391197ee180af9966e474e04363c50f8
Tested locally, and I see the new version displayed in my local browser,
in the footer.
@conorsch conorsch force-pushed the ci-bump-bundled-minifront-2025-03-05 branch from 82f54fd to 32f17cc Compare March 5, 2025 21:15
@conorsch
Copy link
Contributor Author

conorsch commented Mar 5, 2025

Updated the bundled commit hash (from the web repo) from fb5dcb6e7d37facc3fb07e800e8dadc064c40cb9 to 68a1cd50391197ee180af9966e474e04363c50f8, to include penumbra-zone/web#2095.

@conorsch conorsch marked this pull request as ready for review March 5, 2025 21:16
@conorsch conorsch merged commit 3526b0a into main Mar 5, 2025
9 checks passed
@conorsch conorsch deleted the ci-bump-bundled-minifront-2025-03-05 branch March 5, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants