build: make zip file exports deterministic #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As long as the zip files are exported from the same git commit, the resulting archives should be byte-for-byte identical. Having fully reproducible builds will require comprehensive dependency pinning, e.g. via nix flake or similar, to ensure that the wasm artifacts are built identically, but for now, simply clobbering the timestamps of the exported asset files provides decent reproducibility.
|
TalDerei
approved these changes
Mar 5, 2025
turbocrime
pushed a commit
that referenced
this pull request
Mar 6, 2025
As long as the zip files are exported from the same git commit, the resulting archives should be byte-for-byte identical. Having fully reproducible builds will require comprehensive dependency pinning, e.g. via nix flake or similar, to ensure that the wasm artifacts are built identically, but for now, simply clobbering the timestamps of the exported asset files provides decent reproducibility.
TalDerei
pushed a commit
that referenced
this pull request
Mar 6, 2025
As long as the zip files are exported from the same git commit, the resulting archives should be byte-for-byte identical. Having fully reproducible builds will require comprehensive dependency pinning, e.g. via nix flake or similar, to ensure that the wasm artifacts are built identically, but for now, simply clobbering the timestamps of the exported asset files provides decent reproducibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
As long as the zip files are exported from the same git commit, the resulting archives should be byte-for-byte identical. Having fully reproducible builds will require comprehensive dependency pinning, e.g. via nix flake or similar, to ensure that the wasm artifacts are built identically, but for now, simply clobbering the timestamps of the exported asset files provides decent reproducibility.
Related Issue
No request in an issue, simply making opportunistic improvements, as with #2056. Was motivated to try this while updating the bundled assets in penumbra-zone/penumbra#5119.
Checklist Before Requesting Review
^ N/A, as this script only makes changes to build scripts, not to app code.