-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial inclusion of tests #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added some initial tests for verifying the outputs of the db build script. A few issues were identified however, we need to pin the blast version a user can use as outputs between blast versions seem to vary quite a bit, the test output data was updated to meet blast+ version 2.15.0 and the readme's compatibility section was updated. One test currently fails as well, as there is a lack of continuity between outputs in the results.json and the config.json particularly the date fields. It would be nice to make the keys between these two files match in the future as well.
I have added initial tests for the format module verifying outputs, it appeared that the outputs that were passed as examples to the pipeline differed from those generated. It seemed some column headers were mangled and there may have been differences in fields generated. I have updated the test data to reflect the more recent version of locidex
I have added initial tests for the format module verifying outputs, it appeared that the outputs that were passed as examples to the pipeline differed from those generated. It seemed some column headers were mangled and there may have been differences in fields generated. I have updated the test data to reflect the more recent version of locidex
…ion inconsistency
…ion inconsistency
…ion inconsistency
Added tests for format module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR contributing tests to Locidex. The tests will require refactoring as time goes to unify style, syntax and organization of test code.
Some potential changes for future iteration on the tests include:
conftest.py
to organize constants and fixtures in one place