Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial inclusion of tests #10

Merged
merged 45 commits into from
Apr 25, 2024
Merged

Initial inclusion of tests #10

merged 45 commits into from
Apr 25, 2024

Conversation

mattheww95
Copy link
Collaborator

This is the first PR contributing tests to Locidex. The tests will require refactoring as time goes to unify style, syntax and organization of test code.

Some potential changes for future iteration on the tests include:

  • Organizing modules that contains "workflows" into one directory, and modules containing classes into a "classes" directory
  • Constructing a conftest.py to organize constants and fixtures in one place

mattheww95 and others added 30 commits April 4, 2024 11:25
I added some initial tests for verifying the outputs of the db build script. A few issues were identified however, we need to pin the blast version a user can use as outputs between blast versions seem to vary quite a bit, the test output data was updated to meet blast+ version 2.15.0 and the readme's compatibility section was updated. One test currently fails as well, as there is a lack of continuity between outputs in the results.json and the config.json particularly the date fields.

It would be nice to make the keys between these two files match in the future as well.
I have added initial tests for the format module verifying outputs, it appeared that the outputs that were passed as examples to the pipeline differed from those generated. It seemed some column headers were mangled and there may have been differences in fields generated. I have updated the test data to reflect the more recent version of locidex
I have added initial tests for the format module verifying outputs, it appeared that the outputs that were passed as examples to the pipeline differed from those generated. It seemed some column headers were mangled and there may have been differences in fields generated. I have updated the test data to reflect the more recent version of locidex
Added tests for format module
@mattheww95 mattheww95 merged commit 2962f79 into dev Apr 25, 2024
1 check passed
@mattheww95 mattheww95 deleted the tests branch April 25, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants