Compatibility with phpDocumentor Reflection Dockbloc 3 #275
Conversation
dunglas
changed the title
| "repositories": [ | ||
| { | ||
| "type": "vcs", | ||
| "url": "https://github.com/fabiang/ReflectionDocBlock" |
There was a problem hiding this comment.
This can't be merged as is, because composer doesn't inherit this from packages that want to install prophecy.
There was a problem hiding this comment.
Right. It was just to run a Travis build, it will be removed before merge (see the PR description).
|
Travis failure is intended. We only need to get phpDocumentor/ReflectionDocBlock#72 merged and Prophecy will be compatible with Symfony 3.1. |
| use phpDocumentor\Reflection\DocBlock\Tags\Method; | ||
|
|
||
| /** | ||
| * @author Théo FIDRY <[email protected]> |
There was a problem hiding this comment.
please mark this interface and all its implementations as @internal
| fast_finish: true | ||
| include: | ||
| - php: '7.0' | ||
| env: PHPDOCUMENTOR_REFLECTION_DOCBLOCK="~2.0" |
There was a problem hiding this comment.
Maybe take profit to use the new constraint format: ^2.0?
|
A fixed version of Reflection Docblock has been released: phpDocumentor/ReflectionDocBlock#72 (comment) I've updated this PR to use it and I fixed the last remaining comments. It should be ready to be merged now. |
|
I will do a release this evening |
|
Thanks @stof |
Follow up of #264. Allow to use Prophecy (and PHPUnit) with Symfony 3.1.
Test that it works with @fabiang's patch on ReflectionDocBlock merged: phpDocumentor/ReflectionDocBlock#72
The last commit (update of
composer.jsonto use the branch of Fabian) must be removed before the merge in Prophecy.ping @mvriel