Reflection dockbloc 3 #264
Conversation
| private function getClassTagList(\ReflectionClass $reflectionClass) | ||
| { | ||
| try { | ||
| $phpdoc = (null === $this->docBlockFactory || null === $this->contextFactory) |
There was a problem hiding this comment.
That doesn't look like proposed adapter creation. This IF statement checking which Reflection library version is being used is called each time, which is bad performance wise.
There was a problem hiding this comment.
A if statement is nothing compared to all parsing operations involved...
There was a problem hiding this comment.
The main point is that it's not an adapter at all :)
|
@aik099 I went with the simplest solution at hand. But if you prefer I can add a true adapter to retrieve tags and let you guys choose which one you prefer. |
|
@aik099 here you go |
| final class ClassAndInterfaceTagRetriever implements MethodTagRetrieverInterface | ||
| { | ||
| /** | ||
| * @var MethodTagRetrieverInterface |
There was a problem hiding this comment.
To be consistent with property $tagRetriever on class MagicCallPatch, you should add PHPDoc everywhere or nowhere
There was a problem hiding this comment.
yeah this one should be removed
|
phpDocumentor/TypeResolver#16 has been merged and a new version tagged. Tests should pass now, @theofidry can you add a conflict section in |
theofidry
force-pushed
the
reflection-dockbloc-3
branch
from
7502353 to
83be274
Compare
theofidry
force-pushed
the
reflection-dockbloc-3
branch
from
83be274 to
4a97e8b
Compare
|
Still failing |
|
@everzet there is something really weird on docblock side so needs to debug it :/ Maybe I'll have time to check it next week |
|
I'm closing this PR as it is seems to be abandoned. Please feel free to rebase and resubmit it if that's not the case! |
|
As the issue is still valid, any chance this will be re-opened or should a new PR be made? Symfony 3.1 is released and this dependency will prevent people from upgrading. |
|
Well, if @theofidry wants to finish it, I can reopen it. If you want to take it over to finish it instead, you should fetch the branch from @theofidry's fork and then create a new PR with the updated version. |
|
I'm working on this one right now. |
|
@dunglas 👍 |
Follow up of #263:
phpdocumentor/reflection-docblockphpdocumentor/reflection-docblock 3.xcc @dunglas.