Upgrade to reflection-docblock 3 #263
Conversation
dunglas
force-pushed
the
reflection-dockbloc-3
branch
2 times, most recently
from
fc44c53 to
3127866
Compare
dunglas
force-pushed
the
reflection-dockbloc-3
branch
from
3127866 to
bb533ff
Compare
| /** | ||
| * @var Method[] $tagList | ||
| */ | ||
| $tagList = isset($phpdoc) ? $phpdoc->getTagsByName('method') : array(); |
There was a problem hiding this comment.
I don't like the idea of dealing with codepath where the variable may be defined or no. The code should probably be refactored by moving this inside the try/catch
|
This PR means that the min requirement of Prophecy is now PHP 5.5 though. and given that PhpSpec still need to support PHP 5.3+ until June, this is not acceptable. |
|
But currently it means that Prophecy is not usable with Symfony master. As SF 3.1 will be released in May, maybe can we wait June to merge this PR? An alternative is to allow both versions and execute a different logic depending of the installed dependency version. |
|
So Symfony wants Reflection v3, but Prophecy wants Reflection v2? |
|
We need to be able to support the two versions, else it will again cause a lot of problems. Based on the small amount of changes that are required, that's fair to abstract it and uses a basic |
|
I fully agree, will do it ASAP. |
|
Closing in favor of #264 |
Tests will be green when phpDocumentor/TypeResolver#16 and phpDocumentor/ReflectionDocBlock#72 will be merged.