Fix file_get_contents warning in ContextFactory

[dunglas]

Currently, a warning like warning: file_get_contents(): Filename cannot be empty in [...]/prophecy/vendor/phpdocumentor/type-resolver/src/Types/ContextFactory.php line 48 is generated by the library if there is no filename associated with the reflector passed to ContextFactory.

This PR fix this.

[stof]

There is another case breaking: when the filename is eval'd content (or something like that, I don't remember how it looks exactly)

[stof]

Your "fix" makes it impossible to read the docblock of such classes entirely though, even if they don't use aliases. So I'm not sure it is the appropriate fix

[dunglas]

@stof what do you think of this alternative fix?

[stof]

This is much better for the second issue. But I still think that the bug is still there for evaled code. you should add a test for it

[dunglas]

@stof done

[dunglas]

I've pushed a better fix (use file_exists() instead of the previous hackish solution) and squashed commits.

[dunglas]

ping @mvriel

It's a blocking bug for Prophecy integration (see phpspec/prophecy#264).

[theofidry]

👍

[mvriel]

Hiya @dunglas,

Looks good, and thanks for including tests to verify this behaviour. I will merge it.

[dunglas]

Thank you very much @mvriel