-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: replace dgrijalva/jwt-go
with form3tech-oss/jwt-go
#28733
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
The dependency is from etcd: $ go mod why github.com/dgrijalva/jwt-go
warning: ignoring symlink /home/morgo/go/src/github.com/morgo/tidb/plugin/audit
# github.com/dgrijalva/jwt-go
github.com/pingcap/tidb/ddl/util
github.com/pingcap/tidb/ddl/util.test
go.etcd.io/etcd/etcdserver
go.etcd.io/etcd/auth
github.com/dgrijalva/jwt-go The etcd dependency is also holding back the package |
@bb7133 Please address comments |
Can we using https://github.com/golang-jwt/jwt directly? |
This reverts commit 3fd896bcf738e008e04f19d28890c0b2084eeaf1.
ba2b462
to
eeba4da
Compare
I've tried but it doesn't work(see "Alternatives" in description and the commit history). |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: eeba4da
|
What problem does this PR solve?
The
github.com/dgrijalva/jwt-go
is introduced indirectly, but it is not maintained anymore but contains a security vulnerability marked as high. See CVE-2020-26160.Problem Summary:
What is changed and how it works?
Update
go.mod
to replacedgrijalva/jwt-go
withform3tech-oss/jwt-go
(it may NOT a good idea either since this repo is also archived, the recommended replacement isgolang-jwt/jwt
).Check List
Tests
Documentation
Alternatives
dgrijalva/jwt-go
withgolang-jwt/jwt v3.2.2
, but the error is reported forgo mod tidy
: "used for two different module paths".dgrijalva/jwt-go
withgolang-jwt/jwt v3.2.1
, but the fix is not included(upstream fix for security vulnerability from form3tech-oss/jwt-go fork golang-jwt/jwt#40).dgrijalva/jwt-go
withdgrijalva/jwt-go@release_4_0_0
, but the import path has been changed because of the semantic version of Go.Release note