Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/globalkilltest: replace dgrijalva/jwt-go with form3tech-oss/jwt-go #28795

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Oct 13, 2021

What is changed and how it works?

This is a succeeding PR of #28733 , which fix the security vulnerability of CVE-2020-26160.

Check List

Tests

  • No code

Side effects

  • None

Documentation

  • None

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 13, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • dveeden
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2021
Copy link
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking these shows that one has a know security issue (GO-2020-0017) and the other doesn't. Neither of these has a good scorecard.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 13, 2021
@dveeden
Copy link
Contributor

dveeden commented Oct 13, 2021

@bb7133
Copy link
Member Author

bb7133 commented Oct 13, 2021

https://github.com/form3tech-oss/jwt-go/blob/32ab6a8243d7efe20962a5a9df4cbca76db24973/README.md#L1-L3 says we should move to github.com/golang-jwt/jwt instead.

Thanks for the advice, github.com/golang-jwt/jwt is definitely a better fork but didn't make it work(see #28733).

@morgo morgo self-requested a review October 13, 2021 22:55
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 13, 2021
@morgo
Copy link
Contributor

morgo commented Oct 13, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 72518db

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2021
@ti-chi-bot ti-chi-bot merged commit 4807998 into pingcap:master Oct 13, 2021
@bb7133 bb7133 deleted the bb7133/fix_by_replace2 branch December 29, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants