[Dependencies] Update deps #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables for this repo. you could follow readme for more information |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Olshansk
added
core
Olshansk
requested changes
Apr 13, 2023
Olshansk
approved these changes
Apr 13, 2023
github-actions
bot
dismissed stale reviews from themself
The check succeeded, dismissing the review comment.
h5law
added a commit
that referenced
this pull request
Apr 13, 2023
## Description This PR aims to consolidate all the different `TxResult` protobufs and interfaces into a single `TxResult` protobuf located in `shared/core/types` It also gives the `TxIndexer` a persistent path in the 4 config files located in `build/config` ## Issue Fixes N/A ## Type of change Please mark the relevant option(s): - [ ] New feature, functionality or library - [ ] Bug fix - [x] Code health or cleanup - [ ] Major breaking change - [ ] Documentation - [ ] Other ## List of changes - Consolidate `TxResult` protobufs into a single file in the coreTypes module - Give `TxIndexer` a persistent path ## Testing - [x] `make develop_test`; if any code changes were made - [x] [Docker Compose LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md); if any major functionality was changed or introduced - [x] [k8s LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md); if any infrastructure or configuration changes were made ## Required Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added, or updated, [`godoc` format comments](https://go.dev/blog/godoc) on touched members (see: [tip.golang.org/doc/comment](https://tip.golang.org/doc/comment)) - [x] I have tested my changes using the available tooling - [x] I have updated the corresponding CHANGELOG ### If Applicable Checklist - [ ] I have updated the corresponding README(s); local and/or global - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added, or updated, [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding README(s) - [ ] I have added, or updated, documentation and [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*` if I updated `shared/*`README(s)
bryanchriswhite
added a commit
that referenced
this pull request
Apr 14, 2023
bryanchriswhite
added a commit
that referenced
this pull request
Apr 14, 2023
* refactor/consolidate-p2p-modules: (72 commits) chore: update changelog chore: tidy type assertions chore: simplify log fix: module restart `WithHost` (again) chore: improve comments chore: add TECHDEBT comment fix: test helper & add TECHDEBT comment [Shared] `TxResult` consolidation (Merge After #673) (#676) [Dependencies] Update deps (#673) [Infra] Update reviewpad configuration (#675) chore: update changelog fix: re-evaluate options on p2p module `#Start()` chore: group imports chore: `RainTreeConfig#isValid()` returns multierr chore: remove `use_libp2p` from k8s config test: pass `*testing.T` to `getPeerstore` helper chore: improve error log messaging chore: remove unnecessary multierror usage chore: update/improve comments use pod IP for POCKET_P2P_HOSTNAME ...
bryanchriswhite
added a commit
that referenced
this pull request
Apr 14, 2023
* refactor/consolidate-p2p-modules: chore: update changelog chore: tidy type assertions chore: simplify log fix: module restart `WithHost` (again) chore: improve comments chore: add TECHDEBT comment fix: test helper & add TECHDEBT comment [Shared] `TxResult` consolidation (Merge After #673) (#676) [Dependencies] Update deps (#673) [Infra] Update reviewpad configuration (#675)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the dependencies to use
pocket-network/smt(our fork) instead ofcelestiaorg/smtfor the SMT.It is recommended to run the following:
Issue
Fixes N/A
Type of change
Please mark the relevant option(s):
List of changes
go.modand the codebase to use thepocket-network/smtfork of celestia's SMT now it is archivedTesting
make develop_test; if any code changes were madeRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)