Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Update reviewpad configuration #675

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

ferreiratiago
Copy link
Contributor

Description

This pull request introduces a fix to the current reviewpad configuration. Reviewpad is currently failing because the YAML specification is incorrect.

Issue

N/A

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Update to reviewpad.yml used as input for Reviewpad.

Testing

  • make develop_test; if any code changes were made
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@reviewpad
Copy link

reviewpad bot commented Apr 13, 2023

Reviewpad Report (Reviewpad ran in dry-run mode because configuration has changed)

📜 Executed actions

$commentOnce($sprintf("Thank you @%s for this first contribution!", [$author()]))
$removeLabels(["medium", "large"])
$addLabel("small")

@Olshansk Olshansk self-requested a review April 13, 2023 20:56
@Olshansk Olshansk merged commit 5c9fa16 into pokt-network:main Apr 13, 2023
bryanchriswhite added a commit that referenced this pull request Apr 14, 2023
…p-modules

* pokt/main:
  [Shared] `TxResult` consolidation (Merge After #673) (#676)
  [Dependencies] Update deps (#673)
  [Infra] Update reviewpad configuration (#675)
bryanchriswhite added a commit that referenced this pull request Apr 14, 2023
* refactor/consolidate-p2p-modules: (72 commits)
  chore: update changelog
  chore: tidy type assertions
  chore: simplify log
  fix: module restart `WithHost` (again)
  chore: improve comments
  chore: add TECHDEBT comment
  fix: test helper & add TECHDEBT comment
  [Shared] `TxResult` consolidation (Merge After #673) (#676)
  [Dependencies] Update deps (#673)
  [Infra] Update reviewpad configuration (#675)
  chore: update changelog
  fix: re-evaluate options on p2p module `#Start()`
  chore: group imports
  chore: `RainTreeConfig#isValid()` returns multierr
  chore: remove `use_libp2p` from k8s config
  test: pass `*testing.T` to `getPeerstore` helper
  chore: improve error log messaging
  chore: remove unnecessary multierror usage
  chore: update/improve comments
  use pod IP for POCKET_P2P_HOSTNAME
  ...
bryanchriswhite added a commit that referenced this pull request Apr 14, 2023
* refactor/consolidate-p2p-modules:
  chore: update changelog
  chore: tidy type assertions
  chore: simplify log
  fix: module restart `WithHost` (again)
  chore: improve comments
  chore: add TECHDEBT comment
  fix: test helper & add TECHDEBT comment
  [Shared] `TxResult` consolidation (Merge After #673) (#676)
  [Dependencies] Update deps (#673)
  [Infra] Update reviewpad configuration (#675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants