[Code Health] fix: support zero kvcache TTL (#1108)

## Summary

Fix the usage of `isTTLEnabled` to properly support zero TTL (mainly for
testing).

## Issue

- Issue: #1034

## Type of change

Select one or more from the following:

- [ ] New feature, functionality or library
- [ ] Consensus breaking; add the `consensus-breaking` label if so. See
#791 for details
- [ ] Bug fix
- [x] Code health or cleanup
- [ ] Documentation
- [ ] Other (specify)

## Sanity Checklist

- [x] I have updated the GitHub Issue `assignees`, `reviewers`,
`labels`, `project`, `iteration` and `milestone`
- [ ] For docs, I have run `make docusaurus_start`
- [x] For code, I have run `make go_develop_and_test` and `make
test_e2e`
- [ ] For code, I have added the `devnet-test-e2e` label to run E2E
tests in CI
- [ ] For configurations, I have update the documentation
- [ ] I added TODOs where applicable

Author: bryanchriswhite

pkg/cache/memory/config.go

@@ -120,6 +120,14 @@ func WithTTL(ttl time.Duration) KeyValueCacheOptionFn {
 	}
 }
 
+// WithNoTTL effectively disables the cache. Useful for testing.
+func WithNoTTL() KeyValueCacheOptionFn {
+	return func(cfg keyValueConfigI) error {
+		cfg.SetTTL(0)
+		return nil
+	}
+}
+
 // WithMaxVersionAge sets the given maxVersionAge on the configuration; if 0, no historical pruning is performed.
 // It can ONLY be used in the context of a HistoricalKeyValueCache.
 func WithMaxVersionAge(numRetainedVersions int64) KeyValueCacheOptionFn {

pkg/cache/memory/kvcache.go

@@ -61,7 +61,7 @@ func (c *keyValueCache[T]) Get(key string) (T, bool) {
 
 	isTTLEnabled := c.config.ttl > 0
 	isCacheValueExpired := time.Since(cachedValue.cachedAt) > c.config.ttl
-	if isTTLEnabled && isCacheValueExpired {
+	if !isTTLEnabled || isCacheValueExpired {
 		// DEV_NOTE: Not pruning here to optimize concurrent speed:
 		// - Read lock alone would be insufficient for pruning
 		// - Next Set() call will overwrite the value

pkg/cache/memory/kvcache_test.go

@@ -85,6 +85,16 @@ func TestMemoryKeyValueCache(t *testing.T) {
 		require.True(t, isCached)
 		require.Equal(t, "value3", val)
 	})
+
+	t.Run("no TTL", func(t *testing.T) {
+		cache, err := NewKeyValueCache[string](WithNoTTL())
+		require.NoError(t, err)
+
+		// Immediately get the same key after setting.
+		cache.Set("key1", "value1")
+		_, wasCached := cache.Get("key1")
+		require.False(t, wasCached)
+	})
 }
 
 // TestKeyValueCache_ErrorCases exercises various error conditions

pkg/client/query/querycache_test.go

@@ -3,6 +3,7 @@ package query_test
 import (
 	"context"
 	"testing"
+	"time"
 
 	"cosmossdk.io/depinject"
 	coretypes "github.com/cometbft/cometbft/rpc/core/types"
@@ -478,7 +479,7 @@ type queryClients struct {
 
 // supplyCacheDeps supplies all the cache dependencies required by the query clients.
 func supplyCacheDeps(t *testing.T) depinject.Config {
-	opts := memory.WithTTL(0)
+	opts := memory.WithTTL(time.Minute)
 
 	serviceCache, err := memory.NewKeyValueCache[sharedtypes.Service](opts)
 	require.NoError(t, err)