-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Morse->Shannon Migration] Migration module #1034
Open
6 of 13 tasks
Labels
consensus-breaking
IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade.
on-chain
On-chain business logic
protocol
General core protocol related changes
Milestone
Comments
15 tasks
15 tasks
15 tasks
15 tasks
15 tasks
15 tasks
15 tasks
12 tasks
12 tasks
This was referenced Jan 29, 2025
12 tasks
12 tasks
12 tasks
This was
linked to
pull requests
Feb 6, 2025
12 tasks
bryanchriswhite
added a commit
that referenced
this issue
Mar 11, 2025
#1080) ## Summary ```bash scaffold: message claim_morse_application --module migration --signer shannon_dest_address morse_src_address morse_signature stake:coin service_config --response morse_src_address --response claimed_balance:coin --response service_id --response claimed_application_stake:coin --response claimed_at_height:int --response application ``` Changes: - Scaffold `MsgClaimMorseApplication` message ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [x] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
bryanchriswhite
added a commit
that referenced
this issue
Mar 11, 2025
…ods (#1091) ## Summary Extract application staking business logic to `Keeper` methods (as opposed to `msgServer`). **Rationale**: 1. The migration module needs to stake applications/suppliers/gateways (this PR focuses on applications). 2. There's precedent for adding module `Keeper`s as dependencies to other modules, but not `msgServer`s. (see: #1080 (comment)) Changes: - Change the receiver of `#createApplication()` and `#updateApplication()` from `msgServer`, to `Keeper`. - Extract `Keeper#StakeApplication()` from `msgServer#StakeApplication()`. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [x] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [x] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
12 tasks
bryanchriswhite
added a commit
that referenced
this issue
Mar 11, 2025
…er (#1082) ## Summary Implement `MsgClaimMorseApplication` message handler. It should stake, or upstake and replace the service config, a Shannon application, given a previously imported (and unclaimed) `MorseClaimableAccount`. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
bryanchriswhite
added a commit
that referenced
this issue
Mar 11, 2025
…`Keeper` (#1093) ## Summary Extract supplier staking business logic to `Keeper` methods (as opposed to `msgServer`). **Rationale**: 1. The migration module needs to stake applications/suppliers/gateways (this PR focuses on suppliers). 2. There's precedent for adding module `Keeper`s as dependencies to other modules, but not `msgServer`s. (see: #1080 (comment)) Changes: - Change the receiver of `#createSupplier()` and `#updateSupplier()` from `msgServer`, to `Keeper`. - Extract `Keeper#StakeSupplier()` from `msgServer#StakeSupplier()`. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
bryanchriswhite
added a commit
that referenced
this issue
Mar 11, 2025
## Summary ```bash ignite scaffold message claim_morse_supplier --module migration --signer shannon_dest_address morse_src_address morse_signature stake:coin service_config --response morse_src_address --response claimed_balance:coin --response service_id --response claimed_supplier_stake:coin --response claimed_at_height:int --response supplier ``` Changes: - Scaffold `MsgClaimMorseSupplier` - Add `TODO_UPNEXT` comments ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [x] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
bryanchriswhite
added a commit
that referenced
this issue
Mar 11, 2025
…1117) ## Summary Remove unused gateway keeper from the migration module. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [ ] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [ ] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable
red-0ne
added a commit
that referenced
this issue
Mar 12, 2025
## Summary Implement the `MsgClaimMorseAccount` handler. This enables claiming the of the total tokens (unstaked balance plus any actor stakes) of the Morse account to a Shannon account. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
red-0ne
added a commit
that referenced
this issue
Mar 12, 2025
…Claimable$1`/g (#1076) ## Summary Rename `QueryGetMorseClaimableAccount` and `QueryGetMorseClaimableAccountResponse` to remove the "get". ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
red-0ne
added a commit
that referenced
this issue
Mar 12, 2025
…deps (#1079) ## Summary Add application, supplier, and gateway keepers as migration module dependencies. This is in preparation for future work on #1034 which requires staking application, supplier, and gateway actors during Morse account claiming. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
red-0ne
pushed a commit
that referenced
this issue
Mar 12, 2025
## Summary Fix the usage of `isTTLEnabled` to properly support zero TTL (mainly for testing). ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable
red-0ne
added a commit
that referenced
this issue
Mar 12, 2025
#1080) ## Summary ```bash scaffold: message claim_morse_application --module migration --signer shannon_dest_address morse_src_address morse_signature stake:coin service_config --response morse_src_address --response claimed_balance:coin --response service_id --response claimed_application_stake:coin --response claimed_at_height:int --response application ``` Changes: - Scaffold `MsgClaimMorseApplication` message ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [x] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
red-0ne
added a commit
that referenced
this issue
Mar 12, 2025
…ods (#1091) ## Summary Extract application staking business logic to `Keeper` methods (as opposed to `msgServer`). **Rationale**: 1. The migration module needs to stake applications/suppliers/gateways (this PR focuses on applications). 2. There's precedent for adding module `Keeper`s as dependencies to other modules, but not `msgServer`s. (see: #1080 (comment)) Changes: - Change the receiver of `#createApplication()` and `#updateApplication()` from `msgServer`, to `Keeper`. - Extract `Keeper#StakeApplication()` from `msgServer#StakeApplication()`. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [x] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [x] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
red-0ne
added a commit
that referenced
this issue
Mar 12, 2025
…er (#1082) ## Summary Implement `MsgClaimMorseApplication` message handler. It should stake, or upstake and replace the service config, a Shannon application, given a previously imported (and unclaimed) `MorseClaimableAccount`. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
red-0ne
added a commit
that referenced
this issue
Mar 12, 2025
…`Keeper` (#1093) Extract supplier staking business logic to `Keeper` methods (as opposed to `msgServer`). **Rationale**: 1. The migration module needs to stake applications/suppliers/gateways (this PR focuses on suppliers). 2. There's precedent for adding module `Keeper`s as dependencies to other modules, but not `msgServer`s. (see: #1080 (comment)) Changes: - Change the receiver of `#createSupplier()` and `#updateSupplier()` from `msgServer`, to `Keeper`. - Extract `Keeper#StakeSupplier()` from `msgServer#StakeSupplier()`. - Issue: #1034 Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
red-0ne
added a commit
that referenced
this issue
Mar 12, 2025
## Summary ```bash ignite scaffold message claim_morse_supplier --module migration --signer shannon_dest_address morse_src_address morse_signature stake:coin service_config --response morse_src_address --response claimed_balance:coin --response service_id --response claimed_supplier_stake:coin --response claimed_at_height:int --response supplier ``` Changes: - Scaffold `MsgClaimMorseSupplier` - Add `TODO_UPNEXT` comments ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [x] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
red-0ne
pushed a commit
that referenced
this issue
Mar 12, 2025
…1117) ## Summary Remove unused gateway keeper from the migration module. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [ ] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [ ] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
consensus-breaking
IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade.
on-chain
On-chain business logic
protocol
General core protocol related changes
Objective
Enable account (identity and balances) state migration from Morse to Shannon.
Origin Document
https://www.notion.so/buildwithgrove/Technical-Migration-from-Morse-Shannon-173a36edfff6800689fad43fd15287cd
Goals
Deliverables
MorseClaimableAccount
on-chain persisted mapMorseClaimableAccount
#1068poktrolld
CLI command to convert the Morse state export to the Shannon import.MsgCreateMorseAccountState
MsgImportMorseClaimableAccounts
message which persists Morse claimable accounts on Shannon[Morse->Shannon Migration] scaffold: singleMorseAccountState
#1045[Morse->Shannon Migration] feat: implement Morse account state upload #1047MsgImportMorseClaimableAccounts
message #1072MsgClaimMorsePOKT
MsgClaimMorseAccount
[Morse->Shannon Migration] ScaffoldMsgClaimMorsePOKT
#1046MsgClaimMorseAccount
message #1075MsgClaimMorseApplication
MsgClaimMorseApplication
message #1080MsgClaimMorseApplication
handler #1082MsgClaimMorseSupplier
MsgClaimMorseSupplier
#1094MsgClaimMorseSupplier
handler #1095Non-goals / Non-deliverables
General deliverables
Creator: @bryanchriswhite
Co-Owners: @Olshansk
The text was updated successfully, but these errors were encountered: