[Infra] Automatically add the `consensus-breaking` label #791

Olshansk · 2024-09-04T16:21:32Z

Objective

Easily track which changes (and releases) are consensus breaking.

Origin Document

Goals

Make it easy to track which releases are consensus breaking

Deliverables

A GitHub CI workflow that adds the consensus-breaking label automatically when:
- Anything under x/ is modified
- Anything that under x/ imports changes

Non-goals / Non-deliverables

Having complex business logic that gives a 100% guarantee

Creator: @Olshansk
Co-Owners: @okdas

The text was updated successfully, but these errors were encountered:

okdas · 2024-09-04T16:37:56Z

Ha-ha, I looked into that yesterday! Not a very trivial thing to do, but doable.
I believe it will be needed for a Beta TestNet.

Olshansk · 2024-09-04T16:56:58Z

@okdas Can you just leave your ideas here so someone in the community can build it?

## Summary Enable the `rest` service by default in Tilt ## Issue Since the `rest` service is used in E2E tests, it should be enabled by default to avoid non-edited `localnet_config.yaml` files to succeed E2E tests. ![image](https://github.com/user-attachments/assets/88ac37ca-bf9f-4146-83f1-2eafc2f3c829) ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [ ] I have tested my changes using the available tooling - [ ] I have commented my code - [ ] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable

## Summary Bumps golang and cosmos sdk to the latest versions. ## Issue - Discovered that the latest cosmovisor needs a newer go version in #796 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [x] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [ ] I have tested my changes using the available tooling - [ ] I have commented my code - [ ] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable

## Summary * Update `ShannonSDK` dependency. * Fix `InitSDKConfig` already being sealed by `ShannonSDK` ## Issue ![image](https://github.com/user-attachments/assets/6ef7d7e4-af61-4f1d-ad36-1e8e14bef067) ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable

## Summary Add cosmovisor binary to our container images. It will allow us to use cosmovisor in [docker-compose-example](https://github.com/pokt-network/poktroll-docker-compose-example) repo in the future to automate upgrades. ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [x] Other - tooling ## Testing No code was changed - no reason for extensive testing. - Tested Dockerfile.release locally and Dockerfile.dev will be tested by CI. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable

## Summary This PR replaces all embedded `Service` entries with `ServiceId`. Most of the changes are `Service` -> `ServiceId` replacements but special attention has to be put on: * x/session/types/session_header.go * x/shared/helpers/service_configs.go * x/shared/types/service.go * x/service/types/message_add_service.go * proto/poktroll/shared/service.proto * proto/poktroll/session/types.proto * proto/poktroll/session/query.proto A follow-up to update `Shannon-SDK` is expected after approval. E2E tests pass locally. ## Issue ![image](https://github.com/user-attachments/assets/c1feb50b-89c1-4b4f-b4cb-94cfb4ec5ade) ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [ ] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]>

## Summary Implement the `MsgClaimMorseAccount` handler. This enables claiming the of the total tokens (unstaked balance plus any actor stakes) of the Morse account to a Shannon account. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>

…Claimable$1`/g (#1076) ## Summary Rename `QueryGetMorseClaimableAccount` and `QueryGetMorseClaimableAccountResponse` to remove the "get". ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>

…deps (#1079) ## Summary Add application, supplier, and gateway keepers as migration module dependencies. This is in preparation for future work on #1034 which requires staking application, supplier, and gateway actors during Morse account claiming. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>

## Summary Fix the usage of `isTTLEnabled` to properly support zero TTL (mainly for testing). ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable

## Summary Some edits and fixes to the existing Fullnode documentation Changes: - Fixes and tweaks to https://dev.poktroll.com/operate/walkthroughs/full_node_walkthrough - Fixes and tweaks to https://dev.poktroll.com/tools/user_guide/poktrolld_cli ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [x] Documentation - [ ] Other (specify) ## Sanity Checklist - [ ] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [x] For docs, I have run `make docusaurus_start` - [ ] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]>

#1080) ## Summary ```bash scaffold: message claim_morse_application --module migration --signer shannon_dest_address morse_src_address morse_signature stake:coin service_config --response morse_src_address --response claimed_balance:coin --response service_id --response claimed_application_stake:coin --response claimed_at_height:int --response application ``` Changes: - Scaffold `MsgClaimMorseApplication` message ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [x] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>

…ods (#1091) ## Summary Extract application staking business logic to `Keeper` methods (as opposed to `msgServer`). **Rationale**: 1. The migration module needs to stake applications/suppliers/gateways (this PR focuses on applications). 2. There's precedent for adding module `Keeper`s as dependencies to other modules, but not `msgServer`s. (see: #1080 (comment)) Changes: - Change the receiver of `#createApplication()` and `#updateApplication()` from `msgServer`, to `Keeper`. - Extract `Keeper#StakeApplication()` from `msgServer#StakeApplication()`. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [x] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [x] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>

…er (#1082) ## Summary Implement `MsgClaimMorseApplication` message handler. It should stake, or upstake and replace the service config, a Shannon application, given a previously imported (and unclaimed) `MorseClaimableAccount`. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>

…`Keeper` (#1093) ## Summary Extract supplier staking business logic to `Keeper` methods (as opposed to `msgServer`). **Rationale**: 1. The migration module needs to stake applications/suppliers/gateways (this PR focuses on suppliers). 2. There's precedent for adding module `Keeper`s as dependencies to other modules, but not `msgServer`s. (see: #1080 (comment)) Changes: - Change the receiver of `#createSupplier()` and `#updateSupplier()` from `msgServer`, to `Keeper`. - Extract `Keeper#StakeSupplier()` from `msgServer#StakeSupplier()`. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>

## Summary ```bash ignite scaffold message claim_morse_supplier --module migration --signer shannon_dest_address morse_src_address morse_signature stake:coin service_config --response morse_src_address --response claimed_balance:coin --response service_id --response claimed_supplier_stake:coin --response claimed_at_height:int --response supplier ``` Changes: - Scaffold `MsgClaimMorseSupplier` - Add `TODO_UPNEXT` comments ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [x] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>

…1117) ## Summary Remove unused gateway keeper from the migration module. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [ ] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [ ] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable