Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace golang.org/x/exp with stdlib #1112

Merged
merged 1 commit into from
Mar 10, 2025
Merged

refactor: replace golang.org/x/exp with stdlib #1112

merged 1 commit into from
Mar 10, 2025

Conversation

StevenMia
Copy link
Contributor

@StevenMia StevenMia commented Mar 9, 2025 •
edited
Loading

Summary

< One line summary>

Since Go 1.21, the functions in x/exp used here can already be replaced by functions from the standard library.

Changes:

  • < Change 1 >
  • < Change 2 >

Issue

  • Description: < Description >
  • Issue: #{ISSUE_NUMBER}

Type of change

Select one or more from the following:

Sanity Checklist

  • I have updated the GitHub Issue assignees, reviewers, labels, project, iteration and milestone
  • For docs, I have run make docusaurus_start
  • For code, I have run make go_develop_and_test and make test_e2e
  • For code, I have added the devnet-test-e2e label to run E2E tests in CI
  • For configurations, I have update the documentation
  • I added TODOs where applicable

@Olshansk Olshansk self-requested a review March 10, 2025 16:58
@Olshansk Olshansk added the code health Cleans up some code label Mar 10, 2025
@Olshansk Olshansk added this to the Quality of Life milestone Mar 10, 2025
@Olshansk Olshansk removed their assignment Mar 10, 2025
@Olshansk Olshansk merged commit 02251c6 into pokt-network:main Mar 10, 2025
10 checks passed
bryanchriswhite added a commit that referenced this pull request Mar 11, 2025
@bryanchriswhite
Merge branch 'issues/1034/refactor/stake_app' into issues/1034/feat/c…
69fe496 
…laim_morse_app

* issues/1034/refactor/stake_app:
  [Morse->Shannon Migration] scaffold `MsgClaimMorseApplication` message (#1080)
  chore: review feedback improvements
  refactor: replace golang.org/x/exp with stdlib (#1112)
  [DOCS] Revamping the Full Node Documentation (#1096)
red-0ne pushed a commit that referenced this pull request Mar 12, 2025
@StevenMia @red-0ne
refactor: replace golang.org/x/exp with stdlib (#1112)
1a82f18 
Since Go 1.21, the functions in `x/ex`p used here can already be replaced by functions from the standard library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olshansk Olshansk Awaiting requested review from Olshansk

Assignees

@StevenMia StevenMia

Labels
code health Cleans up some code
Projects
Shannon
Status: ✅ Done
Milestone
Quality of Life
Development

Successfully merging this pull request may close these issues.
2 participants
@StevenMia @Olshansk