[Morse->Shannon Migration] refactor: app staking logic as keeper methods #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 71f5112)
…--signer authority
…nnon_dest_address morse_src_address morse_signature --response morse_src_address --response claimed_balance:coin --response claimed_at_height:int
Co-authored-by: Daniel Olshansky <[email protected]>
…deps * issues/1034/refactor/query: self-review improvements chore: review feedback improvements chore: self-review improvements chore: regenerate protobufs chore: review feedback improvements chore: review feedback improvements refactor: MorseStateExport & MorseClaimableAccount fixtures [RelayMiner] Implement relayminer query caching (#1050)
…sg_claim_morse_application * issues/1034/migration/deps: self-review improvements chore: review feedback improvements chore: self-review improvements chore: regenerate protobufs chore: review feedback improvements chore: review feedback improvements refactor: MorseStateExport & MorseClaimableAccount fixtures [RelayMiner] Implement relayminer query caching (#1050)
…issues/1034/refactor/stake_app
* pokt/main: [Morse->Shannon Migration] feat: implement claim Morse account (#1059)
…sg_claim_morse_application
…issues/1034/refactor/stake_app
* pokt/main: [Morse->Shannon Migration] s/`QueryGetMorseClaimable(.+)`/`QueryMorseClaimable$1`/g (#1076)
…sg_claim_morse_application
…issues/1034/refactor/stake_app
…issues/1034/refactor/stake_app
Co-authored-by: Daniel Olshansky <[email protected]>
…issues/1034/refactor/stake_app
…ake_app * pokt/main: [Morse->Shannon Migration] scaffold `MsgClaimMorseApplication` message (#1080)
bryanchriswhite
changed the base branch from
issues/1034/scaffold/msg_claim_morse_application
to
main
bryanchriswhite
added a commit
that referenced
this pull request
Mar 11, 2025
…morse_app * pokt/main: [Morse->Shannon Migration] refactor: app staking logic as keeper methods (#1091)
red-0ne
added a commit
that referenced
this pull request
Mar 12, 2025
…ods (#1091) ## Summary Extract application staking business logic to `Keeper` methods (as opposed to `msgServer`). **Rationale**: 1. The migration module needs to stake applications/suppliers/gateways (this PR focuses on applications). 2. There's precedent for adding module `Keeper`s as dependencies to other modules, but not `msgServer`s. (see: #1080 (comment)) Changes: - Change the receiver of `#createApplication()` and `#updateApplication()` from `msgServer`, to `Keeper`. - Extract `Keeper#StakeApplication()` from `msgServer#StakeApplication()`. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [x] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [x] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: red-0ne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extract application staking business logic to
Keepermethods (as opposed tomsgServer).Rationale:
Keepers as dependencies to other modules, but notmsgServers.(see: [Morse->Shannon Migration] scaffold
MsgClaimMorseApplicationmessage #1080 (comment))Changes:
#createApplication()and#updateApplication()frommsgServer, toKeeper.Keeper#StakeApplication()frommsgServer#StakeApplication().Issue
Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsSanity Checklist
assignees,reviewers,labels,project,iterationandmilestonemake docusaurus_startmake go_develop_and_testandmake test_e2edevnet-test-e2elabel to run E2E tests in CI