Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Morse->Shannon Migration] scaffold & impl.: MsgImportMorseClaimableAccounts message #1072

Merged
merged 28 commits into from
Feb 26, 2025
Merged

[Morse->Shannon Migration] scaffold & impl.: MsgImportMorseClaimableAccounts message #1072

merged 28 commits into from
Feb 26, 2025

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Feb 14, 2025 •
edited
Loading

Summary

ignite scaffold message import_morse_claimable_accounts --module migration --signer authority morse_account_state

Changes:

  • Scaffold MsgImportMorseClaimableAccounts message/query types & handlers
  • Implement MsgImportMorseClaimableAccounts handler

Issue

Type of change

Select one or more from the following:

Sanity Checklist

  • I have updated the GitHub Issue assignees, reviewers, labels, project, iteration and milestone
  • For docs, I have run make docusaurus_start
  • For code, I have run make go_develop_and_test and make test_e2e
  • For code, I have added the devnet-test-e2e label to run E2E tests in CI
  • For configurations, I have update the documentation
  • I added TODOs where applicable

@bryanchriswhite bryanchriswhite self-assigned this Feb 14, 2025
@bryanchriswhite bryanchriswhite added on-chain On-chain business logic consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. migration Morse to Shannon migration related work labels Feb 14, 2025
@bryanchriswhite bryanchriswhite force-pushed the issues/1034/scaffold/msg_import_morse branch 2 times, most recently from 93ded7b to 53e334e Compare February 14, 2025 12:28
@bryanchriswhite bryanchriswhite linked an issue Feb 14, 2025 that may be closed by this pull request
[Morse->Shannon Migration] Migration module #1034
Open
14 tasks
@bryanchriswhite bryanchriswhite changed the title [Morse->Shannon Migration] scaffold: MsgImportMorseClaimableAccounts message [Morse->Shannon Migration] scaffold & impl.: MsgImportMorseClaimableAccounts message Feb 14, 2025
@bryanchriswhite bryanchriswhite mentioned this pull request Feb 14, 2025
Closed
12 tasks
@bryanchriswhite bryanchriswhite changed the base branch from issues/1034/scaffold/morse_claimable_account to main February 14, 2025 12:30
@bryanchriswhite bryanchriswhite force-pushed the issues/1034/scaffold/msg_import_morse branch from 53e334e to dc4be6f Compare February 14, 2025 12:32
@bryanchriswhite bryanchriswhite marked this pull request as ready for review February 14, 2025 16:15
@bryanchriswhite bryanchriswhite mentioned this pull request Feb 12, 2025
Open
14 tasks
@github-actions GitHub Actions
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 1072)
Grafana network dashboard for devnet-issue-1072

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Feb 17, 2025
Olshansk
Olshansk requested changes Feb 24, 2025
View reviewed changes
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few lingering points but I think we have most things figured out so lgtm

@bryanchriswhite bryanchriswhite force-pushed the issues/1034/scaffold/msg_import_morse branch 2 times, most recently from c993a6e to 62a8244 Compare February 25, 2025 10:48
@bryanchriswhite bryanchriswhite force-pushed the issues/1034/scaffold/msg_import_morse branch from 62a8244 to c847898 Compare February 25, 2025 10:52
@bryanchriswhite

This comment was marked as resolved.

Sign in to view
@bryanchriswhite bryanchriswhite force-pushed the issues/1034/scaffold/msg_import_morse branch from c58766e to 6c4d867 Compare February 26, 2025 11:49
Olshansk
Olshansk approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@bryanchriswhite bryanchriswhite merged commit c1de843 into main Feb 26, 2025
10 checks passed
@bryanchriswhite

This comment was marked as outdated.

Sign in to view
bryanchriswhite added a commit that referenced this pull request Feb 27, 2025
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into issues/1034/scaffold/ms…
bd217c6 
…g_claim_morse_account

* pokt/main:
  [Morse->Shannon Migration] scaffold & impl.: `MsgImportMorseClaimableAccounts` message (#1072)
@bryanchriswhite bryanchriswhite deleted the issues/1034/scaffold/msg_import_morse branch February 27, 2025 09:24
bryanchriswhite added a commit that referenced this pull request Feb 27, 2025
@bryanchriswhite
Merge branch 'issues/1034/migration/deps' into issues/1034/scaffold/m…
ca2e6ab 
…sg_claim_morse_application

* issues/1034/migration/deps:
  chore: review feedback improvements
  [Morse->Shannon Migration] scaffold: `MsgClaimMorseAccount` message (#1075)
  Empty commit
  fix: linter error
  [Morse->Shannon Migration] scaffold & impl.: `MsgImportMorseClaimableAccounts` message (#1072)
  chore: review feedback improvements

# Conflicts:
#	x/migration/types/tx.pb.go
bryanchriswhite added a commit that referenced this pull request Feb 27, 2025
@bryanchriswhite
Merge branch 'issues/1034/refactor/stake_app' into issues/1034/feat/c…
0cfbee9 
…laim_morse_app

* issues/1034/refactor/stake_app:
  chore: regenerate protobufs
  chore: review feedback improvements
  [Morse->Shannon Migration] scaffold: `MsgClaimMorseAccount` message (#1075)
  Empty commit
  fix: linter error
  [Morse->Shannon Migration] scaffold & impl.: `MsgImportMorseClaimableAccounts` message (#1072)
  chore: review feedback improvements

# Conflicts:
#	api/poktroll/migration/tx.pulsar.go
#	x/migration/types/tx.pb.go
@bryanchriswhite bryanchriswhite removed a link to an issue Mar 3, 2025
[Morse->Shannon Migration] Migration module #1034
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Olshansk Olshansk Olshansk approved these changes

@red-0ne red-0ne Awaiting requested review from red-0ne

Assignees

@bryanchriswhite bryanchriswhite

Labels
consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. devnet devnet-test-e2e migration Morse to Shannon migration related work on-chain On-chain business logic push-image CI related - pushes images to ghcr.io
Projects
Shannon
Status: ✅ Done
Milestone
Beta TestNet Iteration
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanchriswhite @red-0ne @Olshansk