Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] Test websockets implementation #1099

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[E2E] Test websockets implementation #1099

wants to merge 10 commits into from

Conversation

red-0ne
Copy link
Contributor

@red-0ne red-0ne commented Feb 28, 2025

Summary

Add e2e tests for WebSocket relays in the Pocket Network protocol

Primary Changes:

  • Add WebSocket relay e2e test scenario in relay.feature
  • Implement WebSocket connection handling and event monitoring in test suite
  • Add helper functions for tracking ETH subscription events and session heights

Secondary changes:

  • Update shared parameter querying functionality
  • Fix spacing in async service mining documentation

Type of change

Select one or more from the following:

Sanity Checklist

  • I have updated the GitHub Issue assignees, reviewers, labels, project, iteration and milestone
  • For docs, I have run make docusaurus_start
  • For code, I have run make go_develop_and_test and make test_e2e
  • For code, I have added the devnet-test-e2e label to run E2E tests in CI
  • For configurations, I have update the documentation
  • I added TODOs where applicable

@red-0ne red-0ne added relayminer Changes related to the Relayminer testing Test (or test utils) additions, fixes, improvements or other e2e_story E2E User Story labels Feb 28, 2025
@red-0ne red-0ne added this to the Beta TestNet Iteration milestone Feb 28, 2025
@red-0ne red-0ne self-assigned this Feb 28, 2025
@Olshansk Olshansk requested review from commoddity and removed request for bryanchriswhite March 3, 2025 21:30
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few change requests.

Some of these might not be super easy, so lmk if the time investment is not wroth it in your opinion.

Also, I added @commoddity as a reviewer instead of @bryanchriswhite so he has some visibility into the test framework.

@red-0ne red-0ne requested a review from Olshansk March 6, 2025 18:24
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 1099)
Grafana network dashboard for devnet-issue-1099

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet devnet-test-e2e e2e_story E2E User Story push-image CI related - pushes images to ghcr.io relayminer Changes related to the Relayminer testing Test (or test utils) additions, fixes, improvements or other
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants