Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Multiple Console Sessions #5990

Open
7 of 8 tasks
dhruvisompura opened this issue Jan 14, 2025 · 3 comments
Open
7 of 8 tasks

Epic: Multiple Console Sessions #5990

dhruvisompura opened this issue Jan 14, 2025 · 3 comments
Assignees
Labels
area: console Issues related to Console category. area: ui Issues related to UI category. enhancement New feature or request epic Epic theme: multisession console

Comments

@dhruvisompura
Copy link
Contributor

dhruvisompura commented Jan 14, 2025

Issue to track work for #3173

Description

The runtime debugging pane will be utilized to initially manage sessions while the UI controls to manage sessions is being built. This should allow architectural changes to be introduced before all UI controls are.

Cleanup Work

Open Questions

  • Where should the create console button live? There are pros/cons to the following options:
    • Console Toolbar: We can create a single button that launches the quick pick to create a new console session and remove the dropdown option OR attempt to create the split button in the toolbar to match what is in the Terminal pane.
      • Pro: It aligns with the Terminal pane UI so users have a consistent experience
      • Con: We will not have e2e tests if we go the split button route because of the native context menus which we can't create locators for.
    • Console Tab List: We can add an action bar to the console tab list that lives above all the tabs.
      • Pro: We can have e2e tests for this button
      • Con: It doesn't match Terminal panes, and crowds the tab list pane
  • Do we need the power-cycle option in the multi console session world? Can we scrap it to avoid additional work that requires us to somehow associate a console instance with a session?
    • We can hide the shutdown button, but a user can shutdown a session via q()/exit(). In that situation, the user cannot do anything with the session and will need to create a new one.
    • The R console does tell a user they can quit R by using q(). The console instance will hang around in this case and the user will need to manually delete it. Maybe we should be proactive and dispose of the console instance when the session is disconnected via q()?
    • If we want to bring the power button back and allow re-using a console instance ("power-cycling"), we can include the id of the disconnected session for a console and use that to find the console instance we want to reuse
  • The session picker shows the foreground session. When the foreground session becomes disconnected (for example, via q()/exit()), should we clear the foreground session (set to undefined)? This would more accurately let users know the state of things. We would need to have an unselected state for the console and console tab list.
  • Does the foreground session influence the active interpreter for the Python extension.
    • No it does not. The active interpreter can be set via the Python: Select Interpreter command. This active interpreter is what the Terminal's pane uses.

Related Issues

Closable Issues

@dhruvisompura dhruvisompura added area: console Issues related to Console category. area: ui Issues related to UI category. epic Epic labels Jan 14, 2025
@dhruvisompura dhruvisompura added this to the 2025.03 Pre-Release milestone Jan 14, 2025
@dhruvisompura dhruvisompura self-assigned this Jan 14, 2025
@juliasilge
Copy link
Contributor

After playing with this a bit when reviewing #6363, I agree with #6373 (comment) that the 2/5ths default is too much space for the new tab list. Maybe we can add to cleanup?

@samclark2015 samclark2015 self-assigned this Mar 3, 2025
@ntluong95
Copy link

Will the Jupyter Notebook session be added to the console tab list for consistency?

@juliasilge
Copy link
Contributor

@ntluong95 We don't have plans for that in the initial version of this feature, no, but we will look for feedback about possible enhancements moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: console Issues related to Console category. area: ui Issues related to UI category. enhancement New feature or request epic Epic theme: multisession console
Projects
None yet
Development

No branches or pull requests

4 participants