Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide console tab list #6555

Merged
merged 4 commits into from
Mar 3, 2025
Merged

Hide console tab list #6555

merged 4 commits into from
Mar 3, 2025

Conversation

samclark2015
Copy link
Contributor

@samclark2015 samclark2015 commented Feb 28, 2025 •
edited
Loading

Adds capability for console tab list to hide when one or no session is present.

Screen.Recording.2025-02-28.at.1.07.44.PM.mov

Addresses: #6556

Release Notes

New Features

  • Hides console session list automatically
  • Moves trash button to action bar when hidden, ala Terminal pane

Bug Fixes

  • N/A

QA Notes

e2e: @:console @:sessions

@samclark2015 samclark2015 self-assigned this Feb 28, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:console @:sessions

readme  valid tags

@samclark2015
Copy link
Contributor Author

samclark2015 commented Feb 28, 2025 •
edited
Loading

@jmcphers I believe you're the one who threw this idea out. How's the video look compared to your vision?

@samclark2015 samclark2015 mentioned this pull request Feb 27, 2025
Open
8 tasks
softwarenerd
softwarenerd previously approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@softwarenerd softwarenerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and it works as expected.

@softwarenerd softwarenerd self-requested a review February 28, 2025 20:42
softwarenerd
softwarenerd previously approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@softwarenerd softwarenerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I'm glad we moved the state into PositronConsoleState.

src/vs/workbench/contrib/positronConsole/browser/positronConsoleState.tsx
positronConsoleInstances,
activePositronConsoleInstance: activePositronConsoleInstance
activePositronConsoleInstance: activePositronConsoleInstance,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can just be activePositronConsoleInstance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@softwarenerd We should add a linting rule for trailing commas if we don't want to use them in our repo. I think we just set this rule: https://eslint.style/rules/js/comma-dangle

jmcphers
jmcphers previously approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@jmcphers jmcphers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice!

dhruvisompura
dhruvisompura previously approved these changes Mar 3, 2025
View reviewed changes
src/vs/workbench/contrib/positronConsole/browser/positronConsoleState.tsx
positronConsoleInstances,
activePositronConsoleInstance: activePositronConsoleInstance
activePositronConsoleInstance: activePositronConsoleInstance,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@softwarenerd We should add a linting rule for trailing commas if we don't want to use them in our repo. I think we just set this rule: https://eslint.style/rules/js/comma-dangle

@midleman
Copy link
Contributor

midleman commented Mar 3, 2025

Please update PR description to run tests tagged with @:sessions. Thank you! :)

@midleman midleman force-pushed the feature/console-hide-session-list branch from 9e65401 to 0c6b6f5 Compare March 3, 2025 22:36
@samclark2015 samclark2015 merged commit 38adc0f into main Mar 3, 2025
8 checks passed
@samclark2015 samclark2015 deleted the feature/console-hide-session-list branch March 3, 2025 23:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmcphers jmcphers jmcphers left review comments

@softwarenerd softwarenerd softwarenerd left review comments

@dhruvisompura dhruvisompura dhruvisompura left review comments

Assignees

@samclark2015 samclark2015

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samclark2015 @midleman @jmcphers @softwarenerd @dhruvisompura