Improves Main Interpreter Picker #6363

samclark2015 · 2025-02-14T16:15:14Z

Adds more useable interface for primary interpreter picker.

Addresses #6150, #3596, #2143

Screen.Recording.2025-02-14.at.10.13.45.AM.mov

Release Notes

New Features

Adds action to open Quick Pick to allow user to choose active runtime session, or to create a new one
Replaces main interpreter picker dropdown with button to trigger Quick Pick above
Modifies Positron action bar button to allow display of custom icon (vs. only Codicons as was previously) to support language icons in new interpreter button

Bug Fixes

N/A

QA Notes

e2e: @:interpreter

border prop now enhances button visibility

github-actions · 2025-02-14T16:15:32Z

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:interpreter

^readme ^{valid tags}

…cted

dhruvisompura

Had a couple comments/questions! The overhaul is such an improvement over the old dropdown we had!

src/vs/platform/positronActionBar/browser/components/actionBarButton.css

src/vs/platform/positronActionBar/browser/components/actionBarButton.tsx

dhruvisompura · 2025-02-15T01:47:24Z

src/vs/platform/positronActionBar/browser/components/actionBarButton.tsx

+						className={positronClassNames(
+							'action-bar-button-icon',
+							props.dropdownIndicator,
+						)}


It looks like the props.dropdownIndicator is being evaluated to its string value but I only see .action-bar-button-icon.enabled-split defined in the css file. Is that intentional?

Unsure - I stole this from the original Codicon implementation from @softwarenerd (line 96 sbove)

Co-authored-by: Dhruvi Sompura <[email protected]> Signed-off-by: Sam Clark <[email protected]>

dhruvisompura

Looks great! I had one small suggestion

src/vs/platform/positronActionBar/browser/components/actionBarButton.tsx

softwarenerd

I left a couple of ideas.

src/vs/platform/positronActionBar/browser/components/actionBarButton.css

.../workbench/browser/parts/positronTopActionBar/components/topActionBarInterpretersManager.tsx

samclark2015 · 2025-02-20T15:11:17Z

@juliasilge Hoping to get your feedback re: verbiage here. We are using "Runtime" in this new quickpick, but are curious if "Session" is better fit in advance of the multisession support? Fwiw, this is behind the multisession feature flag.

If yes, I'd propose these changes:

"Select an Active Runtime" -> "Select a Session"
"All Runtimes..." -> "New Session..."
"Start Another Runtime" -> "Start a New Session"

…r-rework

dhruvisompura

LGTM - awaiting any naming changes! 🚀

juliasilge

This is the first time I've played with some of this new UI coming together and it is really nice. 🤩

I agree that we should change some of this wording to use "session"; a benefit of this is that folks have found runtime vs. interpreter confusing and this reduces our use of that in favor of the more straightforward "session".

samclark2015 · 2025-02-20T23:19:48Z

Updated wording using "Session" vs "Runtime":

.../workbench/browser/parts/positronTopActionBar/components/topActionBarInterpretersManager.tsx

…/topActionBarInterpretersManager.tsx Co-authored-by: Dhruvi Sompura <[email protected]> Signed-off-by: Sam Clark <[email protected]>

dhruvisompura

🚀 🚀 🚀

samclark2015 added 5 commits February 13, 2025 12:12

Adds initial infrastructure for new Runtime picker

f4694c3

Update ActionBarButton to indicate affordance

cca7c92

border prop now enhances button visibility

Refactor interpreter manager to use ActionBar context

fbdf967

Improve sorting & filtering for new runtime picker

38371eb

Add icon to new runtime picker when no RT is active

c8e9ecc

samclark2015 requested a review from dhruvisompura February 14, 2025 16:15

samclark2015 self-assigned this Feb 14, 2025

Add indicator in runtime quickpick to show which RT is currently sele…

8776535

…cted

dhruvisompura reviewed Feb 15, 2025

View reviewed changes

samclark2015 and others added 2 commits February 19, 2025 09:53

Removes extra semicolon from CSS

b5c2228

Co-authored-by: Dhruvi Sompura <[email protected]> Signed-off-by: Sam Clark <[email protected]>

Removed erroneous CSS class from action bar button component

a02b35d

samclark2015 marked this pull request as ready for review February 19, 2025 22:00

dhruvisompura previously approved these changes Feb 19, 2025

View reviewed changes

src/vs/platform/positronActionBar/browser/components/actionBarButton.tsx Outdated Show resolved Hide resolved

dhruvisompura requested a review from softwarenerd February 19, 2025 22:33

softwarenerd previously approved these changes Feb 19, 2025

View reviewed changes

src/vs/platform/positronActionBar/browser/components/actionBarButton.css Show resolved Hide resolved

.../workbench/browser/parts/positronTopActionBar/components/topActionBarInterpretersManager.tsx Outdated Show resolved Hide resolved

samclark2015 added 3 commits February 20, 2025 08:40

Fixes unscoped observer of configuration changes

7356033

Adds prop to specify icon dimentions for ActionBarButton

3d8163c

Fixes improper CSS variable layer in ActionBarButton

df3f5c0

samclark2015 dismissed stale reviews from softwarenerd and dhruvisompura via df3f5c0 February 20, 2025 15:05

samclark2015 requested review from softwarenerd and dhruvisompura February 20, 2025 15:11

samclark2015 added 2 commits February 20, 2025 10:39

Merge remote-tracking branch 'origin/main' into feature/runtime-picke…

66d1f85

…r-rework

Merge remote-tracking branch 'origin/main' into feature/runtime-picke…

03dfe00

…r-rework

dhruvisompura previously approved these changes Feb 20, 2025

View reviewed changes

juliasilge previously approved these changes Feb 20, 2025

View reviewed changes

juliasilge mentioned this pull request Feb 20, 2025

Epic: Multiple Console Sessions #5990

Open

8 tasks

Updates some working in new Session Picker

36aeebe

samclark2015 dismissed stale reviews from juliasilge and dhruvisompura via 36aeebe February 20, 2025 23:17

samclark2015 requested a review from dhruvisompura February 20, 2025 23:19

dhruvisompura requested changes Feb 20, 2025

View reviewed changes

.../workbench/browser/parts/positronTopActionBar/components/topActionBarInterpretersManager.tsx Outdated Show resolved Hide resolved

Update src/vs/workbench/browser/parts/positronTopActionBar/components…

f0e796c

…/topActionBarInterpretersManager.tsx Co-authored-by: Dhruvi Sompura <[email protected]> Signed-off-by: Sam Clark <[email protected]>

samclark2015 requested a review from dhruvisompura February 20, 2025 23:31

dhruvisompura approved these changes Feb 20, 2025

View reviewed changes

dhruvisompura merged commit c4908fd into main Feb 21, 2025
8 checks passed

dhruvisompura deleted the feature/runtime-picker-rework branch February 21, 2025 01:16

github-actions bot locked and limited conversation to collaborators Feb 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improves Main Interpreter Picker #6363

Improves Main Interpreter Picker #6363

samclark2015 commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

dhruvisompura left a comment

dhruvisompura Feb 15, 2025

samclark2015 Feb 19, 2025

dhruvisompura left a comment

softwarenerd left a comment

samclark2015 commented Feb 20, 2025

dhruvisompura left a comment •

edited

Loading

juliasilge left a comment

samclark2015 commented Feb 20, 2025

dhruvisompura left a comment

Improves Main Interpreter Picker #6363

Improves Main Interpreter Picker #6363

Conversation

samclark2015 commented Feb 14, 2025 • edited Loading

Release Notes

New Features

Bug Fixes

QA Notes

github-actions bot commented Feb 14, 2025 • edited Loading

dhruvisompura left a comment

Choose a reason for hiding this comment

dhruvisompura Feb 15, 2025

Choose a reason for hiding this comment

samclark2015 Feb 19, 2025

Choose a reason for hiding this comment

dhruvisompura left a comment

Choose a reason for hiding this comment

softwarenerd left a comment

Choose a reason for hiding this comment

samclark2015 commented Feb 20, 2025

dhruvisompura left a comment • edited Loading

Choose a reason for hiding this comment

juliasilge left a comment

Choose a reason for hiding this comment

samclark2015 commented Feb 20, 2025

dhruvisompura left a comment

Choose a reason for hiding this comment

samclark2015 commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

dhruvisompura left a comment •

edited

Loading