Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter dropdown overhaul #6150

Closed
2 tasks done
dhruvisompura opened this issue Jan 29, 2025 · 2 comments
Closed
2 tasks done

Interpreter dropdown overhaul #6150

dhruvisompura opened this issue Jan 29, 2025 · 2 comments
Assignees
Labels
area: console Issues related to Console category. area: ui Issues related to UI category. enhancement New feature or request

Comments

@dhruvisompura
Copy link
Contributor

dhruvisompura commented Jan 29, 2025

The Interpreter dropdown is being simplified as a component to provide a better UX to users as part of the work for multiple sessions.

The dropdown is being replaced with a button that only has two jobs:

  • show the name of the active session/env
  • allow the user to switch between active sessions

The mechanisms for managing a session (start/stop/restart) are moving into the console pane.

When the button is clicked, a user should see a quick pick list to select an active interpreter session. When clicked, the command palette should be rendered with the list of active session from runtimeSessionService.activeSessions

Testing

  • Verify the active session changes for editor, and variables pane when changed from the interpreter dropdown
  • Verify the interpreter dropdown label shows the new active session name when switching sessions via console tab
@dhruvisompura dhruvisompura added the area: console Issues related to Console category. label Jan 29, 2025
@dhruvisompura dhruvisompura added this to the 2025.03 Pre-Release milestone Jan 29, 2025
@dhruvisompura dhruvisompura added enhancement New feature or request area: ui Issues related to UI category. labels Feb 1, 2025
@juliasilge
Copy link
Contributor

Problems with the existing UI reported in #6222

@midleman midleman self-assigned this Feb 18, 2025
@dhruvisompura dhruvisompura removed their assignment Feb 19, 2025
@dhruvisompura dhruvisompura marked this as a duplicate of #2143 Feb 20, 2025
@dhruvisompura dhruvisompura marked this as a duplicate of #3596 Feb 20, 2025
dhruvisompura added a commit that referenced this issue Feb 21, 2025
Adds more useable interface for primary interpreter picker.

Addresses #6150, #3596, #2143


https://github.com/user-attachments/assets/a9aa05ae-3c51-4a3b-bbec-5b0add8a9373


### Release Notes

<!--
Optionally, replace `N/A` with text to be included in the next release
notes.
The `N/A` bullets are ignored. If you refer to one or more Positron
issues,
these issues are used to collect information about the feature or
bugfix, such
as the relevant language pack as determined by Github labels of type
`lang: `.
  The note will automatically be tagged with the language.

These notes are typically filled by the Positron team. If you are an
external
  contributor, you may ignore this section.
-->

#### New Features

- Adds action to open Quick Pick to allow user to choose active runtime
session, or to create a new one
- Replaces main interpreter picker dropdown with button to trigger Quick
Pick above
- Modifies Positron action bar button to allow display of custom icon
(vs. only Codicons as was previously) to support language icons in new
interpreter button

#### Bug Fixes

- N/A


### QA Notes

<!--
  Add additional information for QA on how to validate the change,
  paying special attention to the level of risk, adjacent areas that
  could be affected by the change, and any important contextual
  information not present in the linked issues.
-->

e2e: @:interpreter

---------

Signed-off-by: Sam Clark <[email protected]>
Co-authored-by: Dhruvi Sompura <[email protected]>
@midleman
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2025.03.0-83
OS Version(s) : MacOS

Test scenario(s)

Confirmed that the new session picker works as expected and displays accurate active sessions. Closing out as complete.

The following tests have been added:

  • e2e test to ensure that we are able to interact with the session picker button.
  • e2e test to ensure active session list between console and session picker match

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: console Issues related to Console category. area: ui Issues related to UI category. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants