Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow search in UI for interpreter selection #3596

Closed
juliasilge opened this issue Jun 20, 2024 · 5 comments
Closed

Allow search in UI for interpreter selection #3596

juliasilge opened this issue Jun 20, 2024 · 5 comments
Labels
area: top bar Issues related to Top Bar category. area: ui Issues related to UI category. enhancement New feature or request

Comments

@juliasilge
Copy link
Contributor

When we make some improvements to the interpreter selection UI, we should add the ability to search the runtimes/interpreters:

Screenshot 2024-06-20 at 10 40 40 AM

It's really normal to have ONE ZILLION options here for Python, so better UI would be great. cc @chendaniely

The quick pick that "Python: Select Interpreter" uses feels like a better fit for this task:

Screenshot 2024-06-20 at 10 42 30 AM
@juliasilge juliasilge added enhancement New feature or request area: top bar Issues related to Top Bar category. area: ui Issues related to UI category. labels Jun 20, 2024
@petetronic
Copy link
Collaborator

Could we consider removing the "select alternate runtime version for a language" capability of the top bar interpreter control, and instead leave that to our quick pick option? The existing top bar control could just remain focused on active sessions?

@petetronic petetronic added this to the Release Candidate milestone Jun 20, 2024
@jmcphers
Copy link
Collaborator

I like that idea. We probably still want some gesture for "choose a different version of this language" from the TBID, but it could open the quickpick (or perhaps a dedicated modal with its own search) when invoked.

@DavisVaughan
Copy link
Contributor

Also heavily related to #2235

Note that the Python quick pick has Enter interpreter path... for when autodiscovery fails.

We've already had a few R reports where auto discovery failed because R is in a non standard place, and we need a way for people to be able to supply their own path to R or folder to look in.

@liquidcarbon
Copy link

liquidcarbon commented Jun 28, 2024

image
zoomed in:
image
Not sure how to pick an interpreter in the 2024.6.27 release (Ubuntu 24.04).

Getting this error when trying to browse for an interpreter. The only one available under "start interpreter" is the global one that I don't want to use.

@seeM
Copy link
Contributor

seeM commented Jun 30, 2024

@liquidcarbon thanks for the report! I've replied in #3710.

@dhruvisompura dhruvisompura self-assigned this Feb 5, 2025
@dhruvisompura dhruvisompura removed their assignment Feb 15, 2025
dhruvisompura added a commit that referenced this issue Feb 21, 2025
Adds more useable interface for primary interpreter picker.

Addresses #6150, #3596, #2143


https://github.com/user-attachments/assets/a9aa05ae-3c51-4a3b-bbec-5b0add8a9373


### Release Notes

<!--
Optionally, replace `N/A` with text to be included in the next release
notes.
The `N/A` bullets are ignored. If you refer to one or more Positron
issues,
these issues are used to collect information about the feature or
bugfix, such
as the relevant language pack as determined by Github labels of type
`lang: `.
  The note will automatically be tagged with the language.

These notes are typically filled by the Positron team. If you are an
external
  contributor, you may ignore this section.
-->

#### New Features

- Adds action to open Quick Pick to allow user to choose active runtime
session, or to create a new one
- Replaces main interpreter picker dropdown with button to trigger Quick
Pick above
- Modifies Positron action bar button to allow display of custom icon
(vs. only Codicons as was previously) to support language icons in new
interpreter button

#### Bug Fixes

- N/A


### QA Notes

<!--
  Add additional information for QA on how to validate the change,
  paying special attention to the level of risk, adjacent areas that
  could be affected by the change, and any important contextual
  information not present in the linked issues.
-->

e2e: @:interpreter

---------

Signed-off-by: Sam Clark <[email protected]>
Co-authored-by: Dhruvi Sompura <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: top bar Issues related to Top Bar category. area: ui Issues related to UI category. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants