Code cleanup to correct issues reported by Sonar (Consistency)

[rolnico]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Bug fixes mainly for issues identified as Consistency + Security Hotspot + Reliability

What is the current behavior?
Many issues are raised by Sonar.

What is the new behavior (if this is a feature change)?
Many issues are now gone.
Some methods deprecated since versions strictly older than 5.0 have been deleted (only those I stumbled upon during this PR)

Does this PR introduce a breaking change or deprecate an API?

• Yes
• No

If yes, please check if the following requirements are fulfilled

• The Breaking Change or Deprecated label has been added
• The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

To avoid unsafe Jackson deserialization (see https://rules.sonarsource.com/java/RSPEC-4544/ ), classes implementing the interface BusRef now have to add the Jackson annotation @JsonTypeName(".<ClassName>") (with <ClassName> replaced by the class name. Note the presence of the . before the class name.).
For instance IdBasedBusRef is annotated with @JsonTypeName(".IdBasedBusRef").

Following deprecated methods have been deleted:

• PlatformConfig.setDefaultConfig
• PlatformConfig.moduleExists
• PlatformConfig.getModuleConfig
• PlatformConfigNamedProvider.findBackwardsCompatible
• PlatformConfigNamedProvider.findDefaultBackwardsCompatible
• StandbyAutomaton.getHighVoltageSetPoint
• StandbyAutomaton.setHighVoltageSetPoint
• StandbyAutomaton.getLowVoltageSetPoint
• StandbyAutomaton.setLowVoltageSetPoint
• StandbyAutomatonAdder.withHighVoltageSetPoint
• StandbyAutomatonAdder.withLowVoltageSetPoint
• UndirectedGraph.getMaxVertex (If you override this method, rename it as getVertexCapacity().)

Because of the PlatformConfigNamedProvider. ...BackwardsCompatible methods' deprecation, "default" keyword will not be supported anymore in configuration files. Thus check that you use "default-impl-name" instead of "default" in your configuration, especially in load-flow and dynamic-simulation sections.

The list returned by CandidateComputations.getComputationsNames() is now immutable.

Other information:

[rolnico]

This is the first PR, others are coming

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.7% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarCloud