Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup to correct issues reported by Sonar (Severity: high - part 2) #2974

Merged
merged 142 commits into from
Apr 25, 2024
Merged

Code cleanup to correct issues reported by Sonar (Severity: high - part 2) #2974

merged 142 commits into from
Apr 25, 2024

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented Apr 11, 2024 •
edited by olperr1
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Quality

What is the current behavior?

What is the new behavior (if this is a feature change)?
Follows #2967 and #2971.
Fixes Sonar issues identified as high severity in the modules:

  • commons
  • computation-local
  • contingency
  • dynamic-simulation
  • iidm

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)
Following methods were renamed in ComparisonUtils:

  • compareBytes to assertBytesEquals
  • compareTxt to assertTxtEquals
  • compareXml to assertXmlEquals

rolnico added 30 commits April 5, 2024 15:42
@rolnico
add test to avoid NullPointerException
625fd76 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
fix return statement in MergedBus
5c8d233 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
add test to avoid potential ArrayIndexOutOfBoundsException
6f77f25 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
BREAKING CHANGE - Change JsonTypeInfo to avoid unsafe Jackson deseria…
624c337 
…lization https://rules.sonarsource.com/java/RSPEC-4544/

Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
fix GeneratorModificationActionTest
aa523f1 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
remove peek usage
489d5ff 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
remove duplicated tests
c5d232c 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
remove exceptions not thrown
05de80b 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
if simplifications
7f23910 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
removed unused methods
bcd721f 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
use Supplier from java instead if guava
21da610 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
use Supplier from java instead if guava
b3ce26c 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
ParsingContext declared final
9867b6d 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
XmlStaxContext declared final
6792363 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
replaced deprecated method for ZipFile with SeekableByteChannel
266e337 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
swapped from deprecated org.apache.commons.compress.utils.IOUtils to …
1a38ad6 
…org.apache.commons.io.IOUtils

Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
removed deprecated .newInstance method call
0afcfbc 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
EmptyModuleConfigRepository declared final
e81dc90 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
removed old deprecated methods + replaced guava supplier by java supp…
8541b77 
…lier

Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
replaced deprecated Zipfile constructor by builder
d836935 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
replaced supplier
59fd06e 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
fix
d7a6662 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
fix
06cbf2c 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
fix StandardCharsets.UTF_8
0e3d1b7 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
fix
4e1cf4a 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
fix
7a8c0eb 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
replace supplier
af70c7f 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
replace ZipFile by builder
05235c0 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
catch Exception instead of Throwable
afe04ce 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
group logic in createComputationManager for shortTime and longTime co…
f5ef925 
…mputationManager

Signed-off-by: Nicolas Rol <[email protected]>
rolnico added 9 commits April 11, 2024 15:49
@rolnico
fix import
e17a94e 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
fix javadoc
1f00a26 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
add assertion in test
48ea1bc 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
add assertion in test
7520aa3 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
add assertion in test
33fb7f0 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
replace duplicated strings with constants
7cf7441 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
replace duplicated strings with constants
1fb5090 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
replace duplicated strings with constants
3e3e299 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
fix imports
e2850cd 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico rolnico marked this pull request as ready for review April 16, 2024 06:37
@rolnico rolnico mentioned this pull request Apr 16, 2024
Merged
7 tasks
Base automatically changed from nro/cleanup_severity_high_1 to main April 25, 2024 07:05
olperr1
olperr1 requested changes Apr 25, 2024
View reviewed changes
rolnico added 9 commits April 25, 2024 09:42
@rolnico
Merge branch 'refs/heads/main' into nro/cleanup_severity_high_2
3dd6772 
# Conflicts:
#	action-api/src/test/java/com/powsybl/action/json/JsonActionTest.java
#	cgmes/cgmes-conformity/src/main/java/com/powsybl/cgmes/conformity/CgmesConformity1NetworkCatalog.java
#	cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/export/StateVariablesExport.java
#	cgmes/cgmes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/TransformerConversionTest.java
#	commons/src/main/java/com/powsybl/commons/config/ComponentDefaultConfig.java
#	commons/src/main/java/com/powsybl/commons/parameters/Parameter.java
#	computation/src/main/java/com/powsybl/computation/DefaultComputationManagerConfig.java
#	iidm/iidm-serde/src/main/java/com/powsybl/iidm/serde/XMLImporter.java
#	loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/ValidationUtils.java
#	loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/io/AbstractValidationFormatterWriter.java
#	time-series/time-series-api/src/main/java/com/powsybl/timeseries/TimeSeriesMetadata.java
@rolnico
fix import
b9bb3fc 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
fix class names
209b1e3 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
fix LocalComputationManager
0a22c28 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
rename compareYyy methods to assertYyyEquals
7e92d99 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
fix for review
1f254f7 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
remove unused import
0d610e4 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
fix checkstyle
d46a8eb 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico
fix issues
415d9d4 
Signed-off-by: Nicolas Rol <[email protected]>
@rolnico rolnico added the Breaking Change API is broken label Apr 25, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@olperr1 olperr1 merged commit 91ca8d3 into main Apr 25, 2024
6 checks passed
@olperr1 olperr1 deleted the nro/cleanup_severity_high_2 branch April 25, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olperr1 olperr1 olperr1 approved these changes

Assignees

@rolnico rolnico

Labels
Breaking Change API is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolnico @olperr1