Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: maxIterations no longer used every time #386

Merged
merged 1 commit into from
May 18, 2023
Merged

fix: maxIterations no longer used every time #386

merged 1 commit into from
May 18, 2023
+2 −2

Conversation

clemlak
Copy link
Contributor

@clemlak clemlak commented May 17, 2023

@clemlak clemlak self-assigned this May 17, 2023
@clemlak clemlak requested review from Alexangelj, kmbarry1 and MrToph May 17, 2023 09:01
kmbarry1
kmbarry1 approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@kmbarry1 kmbarry1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Alexangelj
Alexangelj approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@Alexangelj Alexangelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clemlak clemlak merged commit b643d8f into fix/spearbit-may May 18, 2023
@clemlak clemlak deleted the fix/bisection-using-max-iterations branch May 18, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmbarry1 kmbarry1 kmbarry1 approved these changes

@Alexangelj Alexangelj Alexangelj approved these changes

@MrToph MrToph Awaiting requested review from MrToph

Assignees

@clemlak clemlak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clemlak @kmbarry1 @Alexangelj