Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: maxIterations no longer used every time #386

Merged
merged 1 commit into from
May 18, 2023
Merged

fix: maxIterations no longer used every time #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/libraries/BisectionLib.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,5 @@ function bisection(
unchecked {
iterations++; // Increment the iterator.
}
} while (distance >= epsilon && iterations != maxIterations);
} while (distance > epsilon && iterations < maxIterations);
}
2 changes: 1 addition & 1 deletion contracts/libraries/RMM01Lib.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import "./BisectionLib.sol";
uint256 constant SQRT_WAD = 1e9;
uint256 constant WAD = 1 ether;
uint256 constant YEAR = 31556953 seconds;
uint256 constant BISECTION_EPSILON = 0;
uint256 constant BISECTION_EPSILON = 1;

/**
* @title RMM01Lib
Expand Down