Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI :: Add css to reply by email thread button #3374

Closed
namangupta01 opened this issue Sep 21, 2018 · 18 comments · Fixed by #3413
Closed

UI :: Add css to reply by email thread button #3374

namangupta01 opened this issue Sep 21, 2018 · 18 comments · Fixed by #3413
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@namangupta01
Copy link
Member

With the merge of #2669 we have a reply by email feature. And reply by email is stable and working, so now we can start working on some ui improvement for it.

Starting with the basic improvement:
Email thread button on any comment page is a link on clicking which whole conversation thread open-up but the way link looks can be improved with a tooltip saying [click here to view the conversation thread] with some improvement of link button from :
screen shot 2018-09-21 at 2 08 35 pm
to:
screen shot 2018-09-21 at 2 08 57 pm

and also while hovering we can change the default link behaviour to not show underline on link while hovering and also we can show hand-pointer on hovering the link.
This is basic ui improvement so labeling it to first-timers-issue

Comment can be found at: https://publiclab.org/notes/namangupta/02-17-2018/gsoc-proposal#c20071

@shivani-kapania
Copy link
Member

Hi, I'm Shivani Kapania and I'm a final year student at BVCOE, New Delhi. May I try this issue?

@namangupta01
Copy link
Member Author

Yes! Go Ahead. Fell free to ask if you need some help.

@shivani-kapania
Copy link
Member

Definitely.

@SidharthBansal SidharthBansal added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Sep 21, 2018
@jywarren
Copy link
Member

jywarren commented Sep 21, 2018 via email

@jywarren
Copy link
Member

image

@namangupta01
Copy link
Member Author

Yup gmail button looks good

@Paarmita
Copy link
Member

@namangupta01 Can I work on this?

@namangupta01
Copy link
Member Author

namangupta01 commented Sep 23, 2018

Hey @Paarmita, @shivani-kapania is already working on this issue.
You can look for other issues to work on. And as far as i remembered you have already contributed to this project so please look for others issue then instead of doing first-timers-issue as these issues are only for first-timers. If you need help in finding the issue then let me know.
Thanks !

@Paarmita
Copy link
Member

@namangupta01 Yes, plz help in finding one?

@namangupta01
Copy link
Member Author

Have you worked with sidekiq?

@Paarmita
Copy link
Member

@namangupta01 No, I'm not much familiar with the ruby codebase, that's why I was trying first-timer issues

@namangupta01
Copy link
Member Author

Okay then let me find some first-timers-issue.

@namangupta01
Copy link
Member Author

@Paarmita you can try #3407

@shivani-kapania
Copy link
Member

@namangupta01 hi, can you pls assign me a help-wanted issue next?

@namangupta01
Copy link
Member Author

namangupta01 commented Sep 24, 2018 via email

@shivani-kapania
Copy link
Member

Okay, thanks! 👍

It seems that all the issues are assigned but I will create some. You can try from them.

On Mon, Sep 24, 2018, 2:31 PM shivani-kapania @.***> wrote: @namangupta01 https://github.com/namangupta01 hi, can you pls assign me a help-wanted issue next? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3374 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/ATwCYS2fBn1M3vdCJ5SJo7VGznkMMYzUks5ueJ9ugaJpZM4Wzuwt .

@namangupta01
Copy link
Member Author

See #3425, if you want to try that.

@shivani-kapania
Copy link
Member

See #3425, if you want to try that.

Okay, let me take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants