-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI :: Add css to reply by email thread button #3374
Comments
Hi, I'm Shivani Kapania and I'm a final year student at BVCOE, New Delhi. May I try this issue? |
Yes! Go Ahead. Fell free to ask if you need some help. |
Definitely. |
Great! I think it could use styles like a padding of 3-4 px, maybe a
border-radius to give it a rounded look, and a very light grey background
color... what do you think? See how it looks in Gmail!
…On Fri, Sep 21, 2018 at 5:05 AM shivani-kapania ***@***.***> wrote:
Definitely.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3374 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ1yqF-F4_qJFnq9aRtvHoe9Zn4VDks5udKvMgaJpZM4Wzuwt>
.
|
Yup gmail button looks good |
@namangupta01 Can I work on this? |
Hey @Paarmita, @shivani-kapania is already working on this issue. |
@namangupta01 Yes, plz help in finding one? |
Have you worked with |
@namangupta01 No, I'm not much familiar with the ruby codebase, that's why I was trying first-timer issues |
Okay then let me find some first-timers-issue. |
@namangupta01 hi, can you pls assign me a help-wanted issue next? |
It seems that all the issues are assigned but I will create some. You can
try from them.
…On Mon, Sep 24, 2018, 2:31 PM shivani-kapania ***@***.***> wrote:
@namangupta01 <https://github.com/namangupta01> hi, can you pls assign me
a help-wanted issue next?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3374 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATwCYS2fBn1M3vdCJ5SJo7VGznkMMYzUks5ueJ9ugaJpZM4Wzuwt>
.
|
Okay, thanks! 👍
|
See #3425, if you want to try that. |
Okay, let me take a look at it. |
With the merge of #2669 we have a reply by email feature. And reply by email is stable and working, so now we can start working on some ui improvement for it.
Starting with the basic improvement:


Email thread button on any comment page is a link on clicking which whole conversation thread open-up but the way link looks can be improved with a tooltip saying [click here to view the conversation thread] with some improvement of link button from :
to:
and also while hovering we can change the default link behaviour to not show underline on link while hovering and also we can show hand-pointer on hovering the link.
This is basic ui improvement so labeling it to
first-timers-issue
Comment can be found at: https://publiclab.org/notes/namangupta/02-17-2018/gsoc-proposal#c20071
The text was updated successfully, but these errors were encountered: