Reply to comment by email feature #2669

namangupta01 · 2018-04-28T05:03:19Z

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
Closes #2668

tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts
PR is descriptively titled
PR body includes fixes #0000-style reference to original issue #
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

PublicLabBot · 2018-04-28T05:19:02Z

	1 Warning
⚠️	New migrations added. Please update `schema.rb.example` by overwriting it with a copy of the up-to-date `db/schema.rb`. Also, be aware to preserve the MySQL-specific conditions for full-text indices.

	2 Messages
📖	@namangupta01 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

namangupta01 · 2018-05-17T21:27:00Z

Hi @jywarren @MayankKashyap ,
I have completed the reply by email feature! Please have a look.
I have created different commits for different changes instead of one commit in case we need to look at any part of implementation in future and also to keep the things simple.

Here are some screenshots of the working system:

jywarren · 2018-05-18T17:30:08Z

Wow amazing!!!!! Are you doing ok on the test errors here? Would you want me to not squash these commits then, right?

jywarren · 2018-05-18T17:30:21Z

@steviepubliclab

namangupta01 · 2018-05-19T09:52:16Z

I was mean to say if everything goes fine we can squash the commits while merging, i have made different commits untill its ready. And it would be good to squash while merging 👍 .
And the travis error is because of the migration. Should i add the changes to schema.rb.example?
I have fixed some code climate error, please have a look at the remaining errors.

jywarren · 2018-05-23T17:57:14Z

Should i add the changes to schema.rb.example

Yes please!

namangupta01 · 2018-05-23T21:05:43Z

@jywarren After doing rake db:migrate and copying all the data into the schema.rb.example file --lots of unrelated things are changed in file. Any idea?

namangupta01 · 2018-05-23T21:07:43Z

is it something to do with the rails upgradation we did?

namangupta01 · 2018-05-23T21:29:16Z

Got it! I think it was occurring because i was using sqlite3 instead of mysql while running migrations.

https://stackoverflow.com/questions/14842557/rails-changes-schema-rb-for-no-reason

grvsachdeva · 2018-05-23T21:30:23Z

app/models/comment.rb

+    unless node_id.nil?
+      node = Node.find(node_id)
+      user = User.find_by(email: message.from.first)
+      if user.present? && node_id.present?


hi @namangupta01 , is multiple replies from users processed correctly?

yes! i guess so. Why do you think it doesn't?

actually with 2nd and 3rd reply I got some extra info processed when I implemented in my proposal but solved later using another gem. If reverse_markdown gem processing correctly, then great!

Yes, please coordinate to reduce redundant code here if you've both implemented similar processes!

Yes using reverse_markdown_gem we are getting correct processed content.
Have a look!

After 2 replies.

Actually, my concern is this area--

What do you think about this ?

grvsachdeva · 2018-05-23T21:32:56Z

script/mailman_server

+
+# Email Configration for mailman
+Mailman.config.pop3 = {
+  server: 'pop.example.com', 


I guess setting the mail configuration is left.

@Gauravano we can't explicitly write which service we are using....but we can use env variable instead of this.

@icarito any recommendations on how to leave this configuration in this PR?

grvsachdeva · 2018-05-23T21:40:21Z

app/models/comment.rb

+      user = User.find_by(email: message.from.first)
+      if user.present? && node_id.present?
+        message_markdown = ReverseMarkdown.convert message.html_part.body.decoded
+        message_id = message.message_id


nice thinking, it would help in debugging if anything goes wrong.

jywarren · 2018-05-24T15:56:45Z

So to get the tests to pass you'll have to update them so they include the new titles:

https://github.com/namangupta01/plots2/tree/mailman/test/unit/subscription_mailer_test.rb#L31

Great work on putting the ID into the title! :-)

jywarren · 2018-05-24T16:46:50Z

Also looks like you have an error on this line of the template -- comment.node is nil?

https://github.com/namangupta01/plots2/blob/e9ef2a39a699c94ec0760c4ffafdc7e7ed2f884a/app/mailers/comment_mailer.rb#L11

namangupta01 · 2018-06-04T17:52:55Z

Great! I have made the changes --only those related to my pr.

jywarren · 2018-06-05T19:05:18Z

OK - I've just moved the timestamps forward so that the migrations occur in the right order since others have also submitted migrations. Then I'll merge!

…5010014_add_message_id_column_to_comments.rb

jywarren · 2018-06-05T19:24:17Z

db/migrate/20180605010014_add_message_id_column_to_comments.rb

@@ -0,0 +1,5 @@
+class AddMessageIdColumnToComments < ActiveRecord::Migration


Oops, i think i set this timestamp in the future lol -- fixed and we'll see if it passes now.

jywarren · 2018-06-05T19:39:52Z

Hmm, oh now! What did I do to break this? @namangupta01 any ideas? Sorry, just trying to avoid out-of-order migrations!

jywarren · 2018-06-05T20:52:54Z

Done!!!! Publishing to stable.publiclab.org -- very exciting!!!

namangupta01 · 2018-06-05T21:49:37Z

Wow awesome!
Actually @jywarren we have to start the mailman server separately. Will create a pr for its documentation and other configurations.

icarito · 2018-06-06T01:40:17Z

Hi, Great to see this moving forward. Sorry I missed your request for comment. What mailman server do you mean? We do not offer our own SMTP service but use an external service (GMail). Currently localhost SMTP is redirected to this GMail account and in the case of `unstable` and `stable` SMTP mail goes all to "[email protected]" mailbox inside the staging server. The server is not setup to collect mail or accept mail from other servers.

…

On 05/06/18 16:49, Naman Gupta wrote: Wow awesome! Actually @jywarren <https://github.com/jywarren> we have to start the mailman server separately. Will create a pr for its documentation and other configurations. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2669 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMMSw65Hy-7VPjQTlS90KpDstkuqkkrks5t5vz0gaJpZM4TrP19>.

namangupta01 · 2018-06-06T07:53:42Z

No we don't have to setup anything more to setup to collect mail because mailman is doing that work for us. We just have to write the configurations in https://github.com/publiclab/plots2/blob/master/script/mailman_server and then we can start the mailman server which is an incoming mail server which will automatically do the work for us.
We only have to write the proper configurations of the email id which will going to receive all the mails.

icarito · 2018-06-06T07:56:22Z

Okay I see what you mean. @jywarren do you want to create a mailbox for staging/unstable? Otherwise I could setup pop3 in localhost / docker host.

…

On 06/06/18 02:53, Naman Gupta wrote: No we don't have to setup anything more to setup to collect mail because |mailman| is doing that work for us. We just have to write the configurations in https://github.com/publiclab/plots2/blob/master/script/mailman_server and then we can start the mailman server which is an incoming mail server which will automatically do the work for us. We only have to write the proper configurations of the email id which will going to receive all the mails. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2669 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMMS3eGVvsULuXUTKOKe2FcPBeCSV_Jks5t54qJgaJpZM4TrP19>.

jywarren · 2018-06-15T15:42:03Z

Sure, i'll do that now and send you the info.

* Added mailman script * Added migration file for adding comment_via column to comment table * Added reverse_markdown gem for converting html to markdown format * Added migration file for adding message_id column to comment table * Added function to handle received mail to create comment * Added icon for comment added via email to distinguish between the normal comment and reply by email comment * Added node_id in Mailer subjects to be used in reply by email feature * Minor changes * Updated schema.rb.example file * Improved tests * Added migrations * Added migrations * Added migrations * Corrected tests * Added enviroment variable for server address * Added sql sphefic conditions * Unwanted changes in schema.rb.example file is removed * Gem added * Log file is moved to public folder * Corrected tests * forward-date timestamps * Rename 20180605190014_add_message_id_column_to_comments.rb to 20180605010014_add_message_id_column_to_comments.rb * Update schema.rb.example

* Routes modified * Set the views * Modified error messages and user_tag * Add User_Tag as identity and find user_tag * User_sessions_controller modified * User_tag modified * user session controller modified * Checkpoint 1 * checkpoint1 codeclimate errors fixed * Checkpoint 2 * checkpoint 2 * User is created from sign up process successfully * create a usertag_with_omniauth * Search a usertag for oauth * search user_tag existing in db * create a user with omniauth test * LOGIN WORKS * current_user=(user) method removed * sign up correction * routing tests for google oauth * Google auth details saved * Google should return omniauth hash test * sign up and login via provider * sign up and login via provider alternative flow * flash message test added * login user with an email and then connect google provider * . * Changes according to rails 5 done * Changes according to rails 5 done * Environment nomenclature updated * Comments added * Adding application.yml * Submitting a draft (#2747) * Checkbox and JS function added * publish_draft method, routes, mail_notify_stop * coauthor can see and publish * bower update * undo and trying * draft label on dashboard * draft option not visible to first timer * updating bower * debug1 * removing debug statement * button view * view 2 * normal * generate path added * publish privil update * code climate * displaying comment with status1 only * coauthor can view draft * test correction * button text change to save if draft * fixture addition and 1 test * tests , fixtures and minor changes * test addition * codeclimate 1 * codeclimate 2 * codeclimate 3 * minor fixes * enable method=post for data-url image upload at /post (#2675) * enable method=post for data-url image upload at /post * Update editor_controller.rb * Update editor_controller.rb * Fixed first part of Issue #2352 Sorting headers added in wiki index page (#2353) * sorting headers added in wiki index page * replaced sorting header icon * Improved translate widget (#2553) * enhanced translate widget * changed title formatting of widget * Fix the clone command (#2766) * List subscription change (#2767) * Add sidekiq gem (#2738) * added resque gem * made changes for resqu installation * added sidekiq gem * minor changes * modified docker-compose.yml for redis * minor changes * resolve conflicts * Place tag detection and replacing "-" with "" (#2734) * Place tag detection and replacing "-" with "" * Javascript changed * Geocode method added * Tweaks * Tweaks * Tweaks * Tweaks 2 * Tweaks 3 * Update Gemfile.lock * Climate fix * add geocoded tags * Tweaks * Block shift and callback to onComplete * onComplete binded with ajax * place in starting of tag detection * Tweaks * make descriptive tag links move to bottom of page (#2770) * skylight config (#2773) * Reply to comment by email feature (#2669) * Added mailman script * Added migration file for adding comment_via column to comment table * Added reverse_markdown gem for converting html to markdown format * Added migration file for adding message_id column to comment table * Added function to handle received mail to create comment * Added icon for comment added via email to distinguish between the normal comment and reply by email comment * Added node_id in Mailer subjects to be used in reply by email feature * Minor changes * Updated schema.rb.example file * Improved tests * Added migrations * Added migrations * Added migrations * Corrected tests * Added enviroment variable for server address * Added sql sphefic conditions * Unwanted changes in schema.rb.example file is removed * Gem added * Log file is moved to public folder * Corrected tests * forward-date timestamps * Rename 20180605190014_add_message_id_column_to_comments.rb to 20180605010014_add_message_id_column_to_comments.rb * Update schema.rb.example * Added whenever cron update command in Makefile for redeploy-container (#2780) * Fix rss images and email images (#2784) * Fix rss images and email images * Update rss.rss.builder * Update rss_for_tagged_with_author.rss.builder * Update rss.rss.builder * Update rss.rss.builder * Update notify_node_creation.html.erb * Rails 5.0 upgrade (#2726) (#2783) * Rails 5.0 upgrade (#2726) * Upgraded the .gitignore according to rails diff * Initial Gemfile update * Update README.md * Showing message at the top of upgrade page (#2713) * added an upgrade alert tag * Additional questions page tweak (#2721) * added the tag to determine which upgrade is listed on the website * changed regex back * added an upgrade alert tag * added the tag to determine which upgrade is listed on the website * changed regex back * added upgrade after pull and rebase master * Upgrade to Rails 5 * Uncommented composite_primary_key gem * Removed the dual occurence of rails_autolink * Update readme installation, fixes #2729 (#2730) Updates the readme to change the installation instructions, fixes #2729 * Commented activerecord-tableless * Draft display on Dashboard (#2666) * draft display on dashboard * moderator file view permitted * checking * fix * test fix * Added and modified few config files according to railsdiff.org * Removed mass_assignment_sanitizer * Removed composite primary key gem * Removed all attr_accessible in all models * Added composite_primary_key gem again * Downgraded rails and removed few attr_accessible commands * Added strong parameters to the controllers * Added strong parameters gem and also include params.require inside private methods * Added strongparameters.rb file to initializers folder * Removed unnecessary strong_parameter functions * Removed some errors * Changed test command temporarily in .travis.yml * Corrected config/puma.rb file with adding some assets * Added all the config.precompile files in one line * Removed error of problem in updating of user profile * Removed the error while creating a user * Removed error RecordNotFound: Couldn't find Node with 'nid'= * Removed some errors related to ids * Removed comment.reload in comment_controller_test * Track Dockerfiles accross instances. (#2593) * Track Dockerfiles accross instances. * Specify jessie as base * Add commands to build&deploy container with Makefile. (#2746) * Added Sample Cron Job to check working of Whenever Gem (#2715) * Added Sample Cron Job to test Whenever Gem * Added make targets for deployment and cron service start * Added make to image * Tweak Makefile * Fix cron starting command in Makefile * Trim whitespace * Explicitly set jessie as base container * Fixed codeclimate issues * Auto-set wiki slug (#2743) * Added keyword arguments to the tag_model.rb * changed the query statement in search method of node.rb * Force removal of pid file (see docker/compose#1393) * Updated the tests due to change in arguments of search function in node.rb * Removed all the failures from tag_controller_test.rb * Changed the style of params in notes_controller_test.rb * Removed all depreciation warnings related to notes_controller * Removed all deprecation warnings related to image_controller and answers_controller * Removed all deprecation warnings of like_controller and fixed syntax error of answer_controller_test.rb * Removed all dep warnings of editor_controller and syntax error of like_controller_test.rb * removed all errors of answer_controller and some errors of tag_controller.rb * Removed all dep warnings of tag_controller_test.rb * Removed several dep warnings * Removed dep warnings of wiki_controller * Removed dep warnings of talk_controller * Removed dep warnings of legacy_controller_test.rb * Removed some warnings related to comment_controller * Removed the syntax errors * Removed two failures regarding application/xml+rss * Removed 2 failures due to wrong way of passing parameters in tests * Removed 2 failures * Fix params * Remove deprecations * Removed some dep warnings * Remove deprecations * Reverted to nothing => true * Reverted to nothing => true * Avoid rendering more than once in the same action * Removed all dep warnings related to user_tags_controller_test * Remove deprecation * Removed Dep warnings * Fix deprecation * Replace before_filter * Remove deprecation * Remove deprecation * Remove deprecation * Remove deprecation * Bump Ruby version to match Travis' * Simplify email regex to work with Ruby 2.4.1 * Changed the ruby version in Dockerfile * Remove deprecation * Remove deprecation * Removed the depreciation warning related to dynamic :controller and :action segment in routes * Changed the default ActiveRecord to ApplicationRecord in models * Clean Gemfile * Reverted to ['nid'] in tag_controller_test.rb * Changed the tests to rake test:all in .travis.yml * Minor spacing correction in .travis.yml * added a commit in application.js an application.css regarding the precompilation of files * Added more indentation * Small fixes * Separated the rails test and jasmine and coveralls task * Modified ['nid'] to ['node']['nid'] * Removed the extra puts in Rakefile * Changed the serial of tests * Added rake/testtask to Rakefile * Removed puma * Changed to ruby 2.4.1-jessie * Removed the whitelist_attributes command from config/application.rb * Removed two failures due to old usage of params * Fixed some new deprecation warnigs introduced * fixes #2731 'add spam button,line 16 _answers.html.erb' (#2785) * add spam button,line 16 _answers.html.erb * changed comment.ids to answer.ids * changed from comment path to answer * changed comment.parent.path to answer.path * some more cleanup to the button * change answer.aid to answer id * First timers recaptcha Environment Variables (#2786) * Edited the if statement * Added the env variables * Edited ENV variable, and added fallback * Fixed issue#2445 added both direction sort order (#2557) * fixed issue#2445 added both direction sort order * added function get_order_string in tags_controller * Changed get to post (#2788) * Update container definitions to match actual files used. (#2791) * Update container definitions to match actual files used. * Fix paths for running docker-compose.yml from subdir * Fix reference to Dockerfile * Reformat range stats page to table (#2792) * Index page listing for UserTags per issue #2741. (#2753) * Index page listing for UserTags per issue #2741. * Changes per pull request checks. * Removed debugging line. * Added routes to reflect 'groups' naming convention for user_tags per pull request spec. * Tests rewritten after rebase. * Index page listing for UserTags per issue #2741. * Changes per pull request checks. * Removed debugging line. * Added routes to reflect 'groups' naming convention for user_tags per pull request spec. * Fix for test of sort by value. * Update routes.rb for wiki update (#2804) * Update routes.rb * fixes * integration tests for assets (#2806) * integration tests for assets * full assets included * Update assets.rb * Added routes to notes/edit (#2808) * Added routes to notes/edit * Removed redundant notes#edit and added get instead of post in edit actions * Update routes.rb (#2810) * Create OPENID.md * fixing error in home_controller related to `group by` (#2794) * Added group by note.nid * correction * Openid fix with post route and better alert texts (#2815) * Added group by note.nid * correction * reworded openid requests and added post method for 2nd step * adjust message * Update openid_test.rb * Update openid_test.rb * Update openid_test.rb * Update openid_test.rb * Update Dangerfile (#2816) * Update routes.rb to fix embeddable features (#2818) * Update routes.rb * Removed the apostrophe mismatch * Added tests for embed in feature * Delete route for notes (#2820) * Documentation for the reply-by-email to comment feature (#2774) * Added documentation for the reply-by-email to comment feature * Added documentation for the reply-by-email to comment feature * Added documentation for the reply-by-email to comment feature * Added documentation for the reply-by-email to comment feature * Re-order comment options and messages (#2834) * Update _comment.html.erb * Update _comment.html.erb * encoding issue resolved for migrating DrupalUsers to User records (#2257) * encoding issue solved fixes #2209 * minor changes * Rename 20180206161706_add_user_for_orphaned_drupal_user.rb to 20180614000000_add_user_for_orphaned_drupal_user.rb * resolves issue 2520 (#2831) * Emoji autocomplete (#2832) * basic emoji autocomplete * minor changes * minor tweaks * code climate fixes * minor change * changes * remove unnecessary style * Fix parent powertags for wikis like /barnraising (#2844) * application.yml added * Views removed * Application.yml removed * application removed * Docker changes * sign up page removed

* Added mailman script * Added migration file for adding comment_via column to comment table * Added reverse_markdown gem for converting html to markdown format * Added migration file for adding message_id column to comment table * Added function to handle received mail to create comment * Added icon for comment added via email to distinguish between the normal comment and reply by email comment * Added node_id in Mailer subjects to be used in reply by email feature * Minor changes * Updated schema.rb.example file * Improved tests * Added migrations * Added migrations * Added migrations * Corrected tests * Added enviroment variable for server address * Added sql sphefic conditions * Unwanted changes in schema.rb.example file is removed * Gem added * Log file is moved to public folder * Corrected tests * forward-date timestamps * Rename 20180605190014_add_message_id_column_to_comments.rb to 20180605010014_add_message_id_column_to_comments.rb * Update schema.rb.example

* Routes modified * Set the views * Modified error messages and user_tag * Add User_Tag as identity and find user_tag * User_sessions_controller modified * User_tag modified * user session controller modified * Checkpoint 1 * checkpoint1 codeclimate errors fixed * Checkpoint 2 * checkpoint 2 * User is created from sign up process successfully * create a usertag_with_omniauth * Search a usertag for oauth * search user_tag existing in db * create a user with omniauth test * LOGIN WORKS * current_user=(user) method removed * sign up correction * routing tests for google oauth * Google auth details saved * Google should return omniauth hash test * sign up and login via provider * sign up and login via provider alternative flow * flash message test added * login user with an email and then connect google provider * . * Changes according to rails 5 done * Changes according to rails 5 done * Environment nomenclature updated * Comments added * Adding application.yml * Submitting a draft (publiclab#2747) * Checkbox and JS function added * publish_draft method, routes, mail_notify_stop * coauthor can see and publish * bower update * undo and trying * draft label on dashboard * draft option not visible to first timer * updating bower * debug1 * removing debug statement * button view * view 2 * normal * generate path added * publish privil update * code climate * displaying comment with status1 only * coauthor can view draft * test correction * button text change to save if draft * fixture addition and 1 test * tests , fixtures and minor changes * test addition * codeclimate 1 * codeclimate 2 * codeclimate 3 * minor fixes * enable method=post for data-url image upload at /post (publiclab#2675) * enable method=post for data-url image upload at /post * Update editor_controller.rb * Update editor_controller.rb * Fixed first part of Issue publiclab#2352 Sorting headers added in wiki index page (publiclab#2353) * sorting headers added in wiki index page * replaced sorting header icon * Improved translate widget (publiclab#2553) * enhanced translate widget * changed title formatting of widget * Fix the clone command (publiclab#2766) * List subscription change (publiclab#2767) * Add sidekiq gem (publiclab#2738) * added resque gem * made changes for resqu installation * added sidekiq gem * minor changes * modified docker-compose.yml for redis * minor changes * resolve conflicts * Place tag detection and replacing "-" with "" (publiclab#2734) * Place tag detection and replacing "-" with "" * Javascript changed * Geocode method added * Tweaks * Tweaks * Tweaks * Tweaks 2 * Tweaks 3 * Update Gemfile.lock * Climate fix * add geocoded tags * Tweaks * Block shift and callback to onComplete * onComplete binded with ajax * place in starting of tag detection * Tweaks * make descriptive tag links move to bottom of page (publiclab#2770) * skylight config (publiclab#2773) * Reply to comment by email feature (publiclab#2669) * Added mailman script * Added migration file for adding comment_via column to comment table * Added reverse_markdown gem for converting html to markdown format * Added migration file for adding message_id column to comment table * Added function to handle received mail to create comment * Added icon for comment added via email to distinguish between the normal comment and reply by email comment * Added node_id in Mailer subjects to be used in reply by email feature * Minor changes * Updated schema.rb.example file * Improved tests * Added migrations * Added migrations * Added migrations * Corrected tests * Added enviroment variable for server address * Added sql sphefic conditions * Unwanted changes in schema.rb.example file is removed * Gem added * Log file is moved to public folder * Corrected tests * forward-date timestamps * Rename 20180605190014_add_message_id_column_to_comments.rb to 20180605010014_add_message_id_column_to_comments.rb * Update schema.rb.example * Added whenever cron update command in Makefile for redeploy-container (publiclab#2780) * Fix rss images and email images (publiclab#2784) * Fix rss images and email images * Update rss.rss.builder * Update rss_for_tagged_with_author.rss.builder * Update rss.rss.builder * Update rss.rss.builder * Update notify_node_creation.html.erb * Rails 5.0 upgrade (publiclab#2726) (publiclab#2783) * Rails 5.0 upgrade (publiclab#2726) * Upgraded the .gitignore according to rails diff * Initial Gemfile update * Update README.md * Showing message at the top of upgrade page (publiclab#2713) * added an upgrade alert tag * Additional questions page tweak (publiclab#2721) * added the tag to determine which upgrade is listed on the website * changed regex back * added an upgrade alert tag * added the tag to determine which upgrade is listed on the website * changed regex back * added upgrade after pull and rebase master * Upgrade to Rails 5 * Uncommented composite_primary_key gem * Removed the dual occurence of rails_autolink * Update readme installation, fixes publiclab#2729 (publiclab#2730) Updates the readme to change the installation instructions, fixes publiclab#2729 * Commented activerecord-tableless * Draft display on Dashboard (publiclab#2666) * draft display on dashboard * moderator file view permitted * checking * fix * test fix * Added and modified few config files according to railsdiff.org * Removed mass_assignment_sanitizer * Removed composite primary key gem * Removed all attr_accessible in all models * Added composite_primary_key gem again * Downgraded rails and removed few attr_accessible commands * Added strong parameters to the controllers * Added strong parameters gem and also include params.require inside private methods * Added strongparameters.rb file to initializers folder * Removed unnecessary strong_parameter functions * Removed some errors * Changed test command temporarily in .travis.yml * Corrected config/puma.rb file with adding some assets * Added all the config.precompile files in one line * Removed error of problem in updating of user profile * Removed the error while creating a user * Removed error RecordNotFound: Couldn't find Node with 'nid'= * Removed some errors related to ids * Removed comment.reload in comment_controller_test * Track Dockerfiles accross instances. (publiclab#2593) * Track Dockerfiles accross instances. * Specify jessie as base * Add commands to build&deploy container with Makefile. (publiclab#2746) * Added Sample Cron Job to check working of Whenever Gem (publiclab#2715) * Added Sample Cron Job to test Whenever Gem * Added make targets for deployment and cron service start * Added make to image * Tweak Makefile * Fix cron starting command in Makefile * Trim whitespace * Explicitly set jessie as base container * Fixed codeclimate issues * Auto-set wiki slug (publiclab#2743) * Added keyword arguments to the tag_model.rb * changed the query statement in search method of node.rb * Force removal of pid file (see docker/compose#1393) * Updated the tests due to change in arguments of search function in node.rb * Removed all the failures from tag_controller_test.rb * Changed the style of params in notes_controller_test.rb * Removed all depreciation warnings related to notes_controller * Removed all deprecation warnings related to image_controller and answers_controller * Removed all deprecation warnings of like_controller and fixed syntax error of answer_controller_test.rb * Removed all dep warnings of editor_controller and syntax error of like_controller_test.rb * removed all errors of answer_controller and some errors of tag_controller.rb * Removed all dep warnings of tag_controller_test.rb * Removed several dep warnings * Removed dep warnings of wiki_controller * Removed dep warnings of talk_controller * Removed dep warnings of legacy_controller_test.rb * Removed some warnings related to comment_controller * Removed the syntax errors * Removed two failures regarding application/xml+rss * Removed 2 failures due to wrong way of passing parameters in tests * Removed 2 failures * Fix params * Remove deprecations * Removed some dep warnings * Remove deprecations * Reverted to nothing => true * Reverted to nothing => true * Avoid rendering more than once in the same action * Removed all dep warnings related to user_tags_controller_test * Remove deprecation * Removed Dep warnings * Fix deprecation * Replace before_filter * Remove deprecation * Remove deprecation * Remove deprecation * Remove deprecation * Bump Ruby version to match Travis' * Simplify email regex to work with Ruby 2.4.1 * Changed the ruby version in Dockerfile * Remove deprecation * Remove deprecation * Removed the depreciation warning related to dynamic :controller and :action segment in routes * Changed the default ActiveRecord to ApplicationRecord in models * Clean Gemfile * Reverted to ['nid'] in tag_controller_test.rb * Changed the tests to rake test:all in .travis.yml * Minor spacing correction in .travis.yml * added a commit in application.js an application.css regarding the precompilation of files * Added more indentation * Small fixes * Separated the rails test and jasmine and coveralls task * Modified ['nid'] to ['node']['nid'] * Removed the extra puts in Rakefile * Changed the serial of tests * Added rake/testtask to Rakefile * Removed puma * Changed to ruby 2.4.1-jessie * Removed the whitelist_attributes command from config/application.rb * Removed two failures due to old usage of params * Fixed some new deprecation warnigs introduced * fixes publiclab#2731 'add spam button,line 16 _answers.html.erb' (publiclab#2785) * add spam button,line 16 _answers.html.erb * changed comment.ids to answer.ids * changed from comment path to answer * changed comment.parent.path to answer.path * some more cleanup to the button * change answer.aid to answer id * First timers recaptcha Environment Variables (publiclab#2786) * Edited the if statement * Added the env variables * Edited ENV variable, and added fallback * Fixed issue#2445 added both direction sort order (publiclab#2557) * fixed issue#2445 added both direction sort order * added function get_order_string in tags_controller * Changed get to post (publiclab#2788) * Update container definitions to match actual files used. (publiclab#2791) * Update container definitions to match actual files used. * Fix paths for running docker-compose.yml from subdir * Fix reference to Dockerfile * Reformat range stats page to table (publiclab#2792) * Index page listing for UserTags per issue publiclab#2741. (publiclab#2753) * Index page listing for UserTags per issue publiclab#2741. * Changes per pull request checks. * Removed debugging line. * Added routes to reflect 'groups' naming convention for user_tags per pull request spec. * Tests rewritten after rebase. * Index page listing for UserTags per issue publiclab#2741. * Changes per pull request checks. * Removed debugging line. * Added routes to reflect 'groups' naming convention for user_tags per pull request spec. * Fix for test of sort by value. * Update routes.rb for wiki update (publiclab#2804) * Update routes.rb * fixes * integration tests for assets (publiclab#2806) * integration tests for assets * full assets included * Update assets.rb * Added routes to notes/edit (publiclab#2808) * Added routes to notes/edit * Removed redundant notes#edit and added get instead of post in edit actions * Update routes.rb (publiclab#2810) * Create OPENID.md * fixing error in home_controller related to `group by` (publiclab#2794) * Added group by note.nid * correction * Openid fix with post route and better alert texts (publiclab#2815) * Added group by note.nid * correction * reworded openid requests and added post method for 2nd step * adjust message * Update openid_test.rb * Update openid_test.rb * Update openid_test.rb * Update openid_test.rb * Update Dangerfile (publiclab#2816) * Update routes.rb to fix embeddable features (publiclab#2818) * Update routes.rb * Removed the apostrophe mismatch * Added tests for embed in feature * Delete route for notes (publiclab#2820) * Documentation for the reply-by-email to comment feature (publiclab#2774) * Added documentation for the reply-by-email to comment feature * Added documentation for the reply-by-email to comment feature * Added documentation for the reply-by-email to comment feature * Added documentation for the reply-by-email to comment feature * Re-order comment options and messages (publiclab#2834) * Update _comment.html.erb * Update _comment.html.erb * encoding issue resolved for migrating DrupalUsers to User records (publiclab#2257) * encoding issue solved fixes publiclab#2209 * minor changes * Rename 20180206161706_add_user_for_orphaned_drupal_user.rb to 20180614000000_add_user_for_orphaned_drupal_user.rb * resolves issue 2520 (publiclab#2831) * Emoji autocomplete (publiclab#2832) * basic emoji autocomplete * minor changes * minor tweaks * code climate fixes * minor change * changes * remove unnecessary style * Fix parent powertags for wikis like /barnraising (publiclab#2844) * application.yml added * Views removed * Application.yml removed * application removed * Docker changes * sign up page removed

namangupta01 force-pushed the mailman branch 2 times, most recently from 9320b4b to d555963 Compare April 28, 2018 05:11

namangupta01 added the summer-of-code label Apr 28, 2018

ebarry mentioned this pull request May 3, 2018

PLANNING: Email notifications and subscriptions #2104

Closed

29 tasks

namangupta01 force-pushed the mailman branch from d555963 to ba493b9 Compare May 17, 2018 21:15

namangupta01 requested a review from jywarren May 17, 2018 21:27

namangupta01 added the review-me label May 17, 2018

namangupta01 changed the title ~~Added mailman gem for reply by email to comment feature~~ Reply to comment by email feature May 17, 2018

namangupta01 added this to the Email notifications overhaul milestone May 17, 2018

namangupta01 requested review from icarito and a team May 17, 2018 21:32

namangupta01 force-pushed the mailman branch 3 times, most recently from a147b3c to 534f2cb Compare May 19, 2018 09:40

namangupta01 mentioned this pull request May 23, 2018

🙌 Community Check-in #1: Summer of Code Week 2 #2739

Closed

6 tasks

namangupta01 force-pushed the mailman branch from 3231921 to 88d7281 Compare May 23, 2018 20:40

grvsachdeva reviewed May 23, 2018

View reviewed changes

namangupta01 force-pushed the mailman branch from 2ea40de to 67032e3 Compare June 4, 2018 15:43

namangupta01 added 3 commits June 4, 2018 21:19

Gem added

78f5791

Log file is moved to public folder

f7491d8

Corrected tests

b6548a9

forward-date timestamps

26cdf02

ghost assigned jywarren Jun 5, 2018

Rename 20180605190014_add_message_id_column_to_comments.rb to 2018060…

68b143a

…5010014_add_message_id_column_to_comments.rb

jywarren reviewed Jun 5, 2018

View reviewed changes

Update schema.rb.example

7f963bf

jywarren merged commit fad88fd into publiclab:master Jun 5, 2018

ghost removed the review-me label Jun 5, 2018

This was referenced Jun 7, 2018

Discussion regarding the deployment of reply-by-email to comment #2781

Closed

Add Mailman service to docker compose #2823

Merged

icarito mentioned this pull request Jun 21, 2018

Need to start mailman server process in order to fetch incoming mail #2878

Closed

namangupta01 mentioned this pull request Sep 21, 2018

UI :: Add css to reply by email thread button #3374

Closed

This was referenced Nov 30, 2021

Bump marked from 3.0.7 to 4.0.5 #10524

Merged

Bump reverse_markdown from 1.1.0 to 2.1.1 #10501

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reply to comment by email feature #2669

Reply to comment by email feature #2669

namangupta01 commented Apr 28, 2018 •

edited

Loading

PublicLabBot commented Apr 28, 2018 •

edited by plotsbot

Loading

namangupta01 commented May 17, 2018

jywarren commented May 18, 2018

jywarren commented May 18, 2018

namangupta01 commented May 19, 2018

jywarren commented May 23, 2018

namangupta01 commented May 23, 2018 •

edited

Loading

namangupta01 commented May 23, 2018

namangupta01 commented May 23, 2018

grvsachdeva May 23, 2018

namangupta01 May 23, 2018

grvsachdeva May 23, 2018

jywarren May 24, 2018

namangupta01 May 25, 2018

grvsachdeva May 25, 2018

grvsachdeva May 23, 2018

namangupta01 May 23, 2018

grvsachdeva May 23, 2018

jywarren May 24, 2018

grvsachdeva May 23, 2018

jywarren commented May 24, 2018

jywarren commented May 24, 2018

namangupta01 commented Jun 4, 2018

jywarren commented Jun 5, 2018

jywarren Jun 5, 2018

jywarren commented Jun 5, 2018

jywarren commented Jun 5, 2018

namangupta01 commented Jun 5, 2018

icarito commented Jun 6, 2018 via email

namangupta01 commented Jun 6, 2018

icarito commented Jun 6, 2018 via email

jywarren commented Jun 15, 2018

		@@ -0,0 +1,5 @@
		class AddMessageIdColumnToComments < ActiveRecord::Migration

Reply to comment by email feature #2669

Reply to comment by email feature #2669

Conversation

namangupta01 commented Apr 28, 2018 • edited Loading

PublicLabBot commented Apr 28, 2018 • edited by plotsbot Loading

namangupta01 commented May 17, 2018

jywarren commented May 18, 2018

jywarren commented May 18, 2018

namangupta01 commented May 19, 2018

jywarren commented May 23, 2018

namangupta01 commented May 23, 2018 • edited Loading

namangupta01 commented May 23, 2018

namangupta01 commented May 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jywarren commented May 24, 2018

jywarren commented May 24, 2018

namangupta01 commented Jun 4, 2018

jywarren commented Jun 5, 2018

Choose a reason for hiding this comment

jywarren commented Jun 5, 2018

jywarren commented Jun 5, 2018

namangupta01 commented Jun 5, 2018

icarito commented Jun 6, 2018 via email

namangupta01 commented Jun 6, 2018

icarito commented Jun 6, 2018 via email

jywarren commented Jun 15, 2018

namangupta01 commented Apr 28, 2018 •

edited

Loading

PublicLabBot commented Apr 28, 2018 •

edited by plotsbot

Loading

namangupta01 commented May 23, 2018 •

edited

Loading