Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra info in assertion is truncated even with -vv #12307

Closed
The-Compiler opened this issue May 11, 2024 · 3 comments · May be fixed by #12322
Closed

Extra info in assertion is truncated even with -vv #12307

The-Compiler opened this issue May 11, 2024 · 3 comments · May be fixed by #12322
Labels
topic: reporting related to terminal output and user-facing messages and errors topic: rewrite related to the assertion rewrite mechanism type: bug problem that needs to be addressed

Comments

@The-Compiler
Copy link
Member

We've had a couple of related issue, but I couldn't find this specific case reported before.

With the current git main:

platform linux -- Python 3.12.3, pytest-8.2.0.dev99+g1d322ffb4, pluggy-1.5.0

doing something like:

def test_x():
    assert False, dir("")

results in:

    def test_x():
>       assert False, dir("")
E       AssertionError: ['__add__', '__class__', '__contains__', '__delattr__', '__dir__', '__doc__', ...]
E       assert False

and even with -vv, the output never seems to get more verbose.
@Zac-HD Zac-HD added type: bug problem that needs to be addressed topic: reporting related to terminal output and user-facing messages and errors topic: rewrite related to the assertion rewrite mechanism labels May 13, 2024
@The-Compiler
Copy link
Member Author

Might be related to (if not a duplicate of) #6682?

@ssbarnea ssbarnea mentioned this issue May 15, 2024
Draft
@ncoghlan ncoghlan mentioned this issue Jul 30, 2024
Closed
@nicoddemus nicoddemus mentioned this issue Jul 30, 2024
Merged
nicoddemus added a commit that referenced this issue Aug 5, 2024
@nicoddemus
Obey verbosity level when printing 'msg' part of assertions (#12662)
bc1e17e 
Seems like we just missed that case when more fine-grained verbosity levels were added.

Fixes #6682, #12307
patchback bot pushed a commit that referenced this issue Aug 5, 2024
@nicoddemus @patchback
Obey verbosity level when printing 'msg' part of assertions (#12662)
bce3972 
Seems like we just missed that case when more fine-grained verbosity levels were added.

Fixes #6682, #12307

(cherry picked from commit bc1e17e)
@patchback patchback bot mentioned this issue Aug 5, 2024
Merged
nicoddemus added a commit that referenced this issue Aug 5, 2024
@patchback @nicoddemus
Obey verbosity level when printing 'msg' part of assertions (#12662) (#…
dcff37a 
…12687)

Seems like we just missed that case when more fine-grained verbosity levels were added.

Fixes #6682, #12307

(cherry picked from commit bc1e17e)

Co-authored-by: Bruno Oliveira <[email protected]>
@reaganjlee
Copy link
Contributor

This should be closed I believe given @nicoddemus's fix

@RonnyPfannschmidt
Copy link
Member

closing as fixed by #12662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: reporting related to terminal output and user-facing messages and errors topic: rewrite related to the assertion rewrite mechanism type: bug problem that needs to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Truncate objects the same way we truncate other messages pytest-dev/pytest
4 participants
@RonnyPfannschmidt @The-Compiler @Zac-HD @reaganjlee