Obey verbosity level when printing 'msg' part of assertions #12662
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like we just missed that case when more fine-grained verbosity levels were added. Fixes pytest-dev#6682
psf-chronographer
bot
added
the
bot:chronographer:provided
nicoddemus
added
the
backport 8.3.x
|
Gentle ping @RonnyPfannschmidt @bluetech @Pierre-Sassoulas |
RonnyPfannschmidt
approved these changes
Aug 3, 2024
|
(I liked the regex check, very elegant) |
Backport to 8.3.x: 💚 backport PR created✅ Backport PR branch: Backported as #12687 🤖 @patchback |
nicoddemus
added a commit
that referenced
this pull request
Aug 5, 2024
…12687) Seems like we just missed that case when more fine-grained verbosity levels were added. Fixes #6682, #12307 (cherry picked from commit bc1e17e) Co-authored-by: Bruno Oliveira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like we just missed that case when more fine-grained verbosity levels were added.
Fixes #6682, #12307