fix fixture for python3 fixes #2334 #2814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
requested changes
Oct 5, 2017
| "class fixtures not supported (may be in the future)") | ||
| if getattr(function, "_pytestfixturefunction", False): | ||
| function = copy_func(function) | ||
|
|
There was a problem hiding this comment.
the assigment was reoved, as such this is broken
from my pov we should not copy the function but warn about the mistake reserving the right to fail later on
There was a problem hiding this comment.
I agree that copying the function is dangerous. I think we can target features and raise an error if @pytest.fixture is being applied more than once to the same function.
It is clearly a problem and if it is working is mostly by accident.
|
I create new PR providing these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not the completed PR.
#2334
I discovered that problem exists because FixtureMaker creates additional attr in function object.
This attr is replaced each time we using it,
The solution is to copy function object when
_pytestfixturefunctionexists.But function that im using to copy function is only for python3.