-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide error fixture applied to the same func #2849
provide error fixture applied to the same func #2849
Conversation
57f7d56
to
aafe1b8
Compare
provide error fixture applied to the same func provide error fixture applied to the same func
aafe1b8
to
cfd16d0
Compare
i am fairly certain that unless we raise a deprecation warning for one feature iteration at least its going to break people quite a bit unexpectedly @nicoddemus i'd like your opinion on that |
oh, i just cross-checked the prior pr in #2814 - since @nicoddemus suggested the error it may be fine |
for completeness please add a unittest something like
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ApaDoctor! Agree that we should add a test for it.
I updated the changelog a bit, hope you don't mind (I gotta say that I just love being able to quickly edit files directly while reviewing a PR 😄 )
@nicoddemus thanks for finishing it up |
Ref #2334