Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide error fixture applied to the same func #2849

Merged
merged 4 commits into from
Apr 24, 2018
Merged

provide error fixture applied to the same func #2849

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfd16d0
provide error fixture applied to the same func
ApaDoctor Oct 5, 2017
a7a39f1
Update CHANGELOG formatting
nicoddemus Oct 18, 2017
03850cf
Add test for applying fixture twice
nicoddemus Apr 24, 2018
132fb61
Merge remote-tracking branch 'upstream/features' into ApaDoctor/disab…
nicoddemus Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions _pytest/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,6 +827,10 @@ def __call__(self, function):
if isclass(function):
raise ValueError(
"class fixtures not supported (may be in the future)")
if getattr(function, "_pytestfixturefunction", False):
raise ValueError(
"fixture is being applied more than once to the same function")

function._pytestfixturefunction = self
return function

Expand Down
1 change: 1 addition & 0 deletions changelog/2334.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Now when ``@pytest.fixture`` is applied more than once to the same function a ``ValueError`` is raised. This buggy behavior would cause surprising problems and if was working for a test suite it was mostly by accident.