-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update remotes #1067
Update remotes #1067
Conversation
|
||
remotes <- compact(lapply(pkgs, package2remote)) | ||
|
||
if (!isTRUE(force)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there are reason to do this here, rather than relying on the individual install methods?
jimhester@ed000dd does as you suggest moving the SHA checking into I also moved the remote updating into |
package2remote <- function(x, ...) { | ||
x <- packageDescription(x) | ||
if (is.null(x$RemoteType)) { | ||
return(NULL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about having a CRAN package type here? That might make it easy for update_packages()
to work with everything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been done at jimhester@8bdb10b, let me know your thoughts...
While you're at it: Is there a way to not install/upgrade remotes, just to install a single package? I tried
to no avail. (Now I know that the "metadata" arg does something different, never mind.) To me, it looks like install_dev_remotes() is called unconditionally. For now, I'll be using |
@krlmlr You are correct, the remotes should respect |
16dbe00
to
715b596
Compare
6bca5cb
to
c35630c
Compare
52cdd10
to
8378138
Compare
The builds are taking too long and failing due to unrelated issues.
7dcf536
to
d83a841
Compare
Current coverage is 42.33%@@ master #1067 diff @@
=====================================
Files 85 86 +1
Lines 4310 4429 +119
Methods 0 0
Branches 0 0
=====================================
+ Hits 1853 1875 +22
- Misses 2457 2554 +97
Partials 0 0
|
[ci skip]
Implementation of
update_remotes
as defined in #1037, #975.I also improved the SVN support to include the SVN revision, so this will now work with all remotes in devtools.
I still need to add tests for this, but this works with a simple test on all remote types on my machine.