Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augmented update_packages to update those installed from remote repos #975

Closed
wants to merge 2 commits into from
Closed

Conversation

bearloga
Copy link

@bearloga bearloga commented Nov 9, 2015

  • Moved update_packages() from deps.R to update.R
  • Make pkgs argument optional in update_packages to allow updating all
    installed packages (installed from CRAN or otherwise)
  • Added utility functions: get_local_info() and get_remote_sha1() which
    are used in update_remotes()

P.S. It looks like git2r is getting a remote_ls (ropensci/git2r#172) but that hasn't propagated yet, so I'm using git ls-remote at OS level for now. Update: using git2r::remote_ls() now

- Moved update_packages() from deps.R to update.R
- Make pkgs argument optional in update_packages to allow updating all
installed packages (installed from CRAN or otherwise)
- Added utility functions: get_local_info() and get_remote_sha1() which
are used in update_remotes()
@bhive01
Copy link

bhive01 commented Jan 7, 2016

The errors for this are:

* checking Rd cross-references ... WARNING
Missing link or links in documentation object 'package_deps.Rd':
  ‘install_packages’
See section 'Cross-references' in the 'Writing R Extensions' manual.
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... WARNING
Documented arguments not in \usage in documentation object 'update_packages':
  ‘ask’
Functions with \usage entries need to have the appropriate \alias
entries, and all their arguments documented.
The \usage entries must correspond to syntactically valid R code.
See chapter ‘Writing R documentation files’ in the ‘Writing R
Extensions’ manual.

Looks like the build issue is related to documentation.

I'm kind of awful at the roxygen stuff, but it looks like the issue is on line 14/15 of update.R. The ask parameter is not used in update_packages(), but in update_remotes(). Maybe delete that and see if it builds?

@bhive01
Copy link

bhive01 commented Jan 9, 2016

Bitchin'. Your move @hadley. 😜

@hadley
Copy link
Member

hadley commented Jan 12, 2016

@jimhester will take the first round of review, and then I'll take a look

@hadley
Copy link
Member

hadley commented Jan 20, 2016

Hi @bearloga - we really appreciate the pull request but it's currently too far from how we'd implement it that I don't think it's useful to iterate here. In a few minutes, I'll create a new issue describing the problem, and quickly dumping my thoughts on the issue. We'll probably tackle it ourselves for 1.11, but thanks for the idea and the sketch implementation that shows it shouldn't be too much work!

@hadley hadley closed this Jan 20, 2016
@jimhester jimhester mentioned this pull request Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants