Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docstring for rclcpp::Node::now() and rclcpp::LifecycleNode::now() #2696

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Update docstring for rclcpp::Node::now() and rclcpp::LifecycleNode::now() #2696

merged 1 commit into from
Dec 4, 2024

Conversation

roncapat
Copy link
Contributor

@roncapat roncapat commented Dec 3, 2024 •
edited
Loading

Closes #2688

CC: @fujitatomoya

@roncapat roncapat marked this pull request as ready for review December 3, 2024 14:29
fujitatomoya
fujitatomoya requested changes Dec 3, 2024
View reviewed changes
fujitatomoya
fujitatomoya approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@roncapat DCO missing, can you fix that?

@roncapat
Update docstring for rclcpp::Node::now()
c9e15d0 
Signed-off-by: Patrick Roncagliolo <[email protected]>
@roncapat
Copy link
Contributor Author

roncapat commented Dec 4, 2024

Done :)

@fujitatomoya fujitatomoya merged commit a7f05a9 into ros2:rolling Dec 4, 2024
3 checks passed
HarunTeper pushed a commit to HarunTeper/rclcpp that referenced this pull request Dec 9, 2024
@roncapat @HarunTeper
Update docstring for rclcpp::Node::now() (ros2#2696)
3ad090b 
Signed-off-by: Patrick Roncagliolo <[email protected]>
Signed-off-by: HarunTeper <[email protected]>
HarunTeper pushed a commit to HarunTeper/rclcpp that referenced this pull request Dec 9, 2024
@roncapat @HarunTeper
Update docstring for rclcpp::Node::now() (ros2#2696)
86d1f33 
Signed-off-by: Patrick Roncagliolo <[email protected]>
Signed-off-by: HarunTeper <[email protected]>
HarunTeper pushed a commit to HarunTeper/rclcpp that referenced this pull request Mar 3, 2025
@roncapat @HarunTeper
Update docstring for rclcpp::Node::now() (ros2#2696)
75643b8 
Signed-off-by: Patrick Roncagliolo <[email protected]>
Signed-off-by: HarunTeper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor suggestion for rclcpp::Node::now() documentation string
2 participants
@roncapat @fujitatomoya