Use crypto.Signer instead of *rsa.PrivateKey #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea - I've got my own use-case for this coming along shortly too. I don't think this is worth cutting a v2 over, so let's try to keep it backwards compatible for now, but I'll also start putting together a list of things for a future v2. Seem reasonable? |
|
Sounds good. I can update the diff to implement this in a backward compatible way. |
|
What I really wanted was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X509KeyStore currently only supports RSA private keys due to the type used and was wondering if we could expand support to any
crypto.Signer.This is the minimal diff, but it is backward incompatible from an API perspective so merging would imply a v2. Alternatively, I could update the diff to introduce new types and maintain backward compatibility (but wanted to start a convo first before I went further with this).