Add API for using crypto.Signer with SigningContext #89
+245
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main purpose of the pull request adds a `crypto.Signer` to `SigningContext` to enable signing by an HSM. This change also enables signing with ECDSA keypairs. * Added `NewSigningContext` to construct a `SigningContext` that holds a `crypto.Signer` and the certificate chain and is mutually exclusive with `X509KeyStore` * If the `SigningContext` has a non-nil `KeyStore`, it uses that instead to maintain backwards compatibility and not break existing code. * Use `x509.Certificate`'s `CheckSignature` method instead of the RSA public key to support validation of ECDSA signatures * Added constants and changed the maps slightly to support ECDSA signature methods. Co-authored-by: charredlot <[email protected]>
mdwn
force-pushed
the
mike.wilson/support-crypto-signer
branch
from
06597d9 to
dcbd738
Compare
|
Looks good, thanks to both of you for taking this on! |
This was referenced Mar 8, 2023
This was referenced Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of the pull request adds a
crypto.SignertoSigningContextto enable signing by an HSM. This change also enables signing with ECDSA keypairs.NewSigningContextto construct aSigningContextthat holds acrypto.Signerand the certificate chain and is mutually exclusive withX509KeyStoreSigningContexthas a non-nilKeyStore, it uses that instead to maintain backwards compatibility and not break existing code.x509.Certificate'sCheckSignaturemethod instead of the RSA public key to support validation of ECDSA signaturesNote: This is just a slightly updated version of https://github.com/russellhaering/goxmldsig/pull/44/files. Full credit deserves to go to @charredlot.