Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation incorrect -- Docker v1.10 or higher required #981

Closed
apeschel opened this issue May 18, 2017 · 1 comment
Closed

Documentation incorrect -- Docker v1.10 or higher required #981

apeschel opened this issue May 18, 2017 · 1 comment
Labels
docker documentation Documentation should be extended or updated

Comments

@apeschel
Copy link
Contributor

apeschel commented May 18, 2017

The documentation for the Docker packager states that Docker v1.3 or higher is required, as seen here:

https://github.com/sbt/sbt-native-packager/blob/2c3946a235ee35b8f19e9a985a6ea3fc1ae362b0/src/sphinx/formats/docker.rst

However, the packager takes advantage of features that were only added in Docker v1.10. The packager uses a docker build command of the form docker build -t [version] -t [latest] ., which lists multiple tags:

https://github.com/sbt/sbt-native-packager/blob/master/src/main/scala/com/typesafe/sbt/packager/docker/DockerPlugin.scala#L92-L97

However, support for multiple tags with the build command was only added in Docker v1.10:

moby/moby#15780

I'm not sure if the preference would be to modify the code to support Docker v1.3 as stated, or to update the documentation to require v1.10.

@muuki88 muuki88 added docker documentation Documentation should be extended or updated labels May 24, 2017
@muuki88
Copy link
Contributor

muuki88 commented May 24, 2017

Thanks @apeschel for recognizing. We should update the documentation. Would you like to make a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker documentation Documentation should be extended or updated
Projects
None yet
Development

No branches or pull requests

2 participants