Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/GHA: add codespell check, fix typos found #72

Closed
wants to merge 1 commit into from

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Sep 15, 2021

Inspired by #69 (comment)

  1. Fix a few typos found by codespell:

    ./seccomp_internal.go:820: reponse ==> response
    ./seccomp.go:267: notication ==> notification
    ./seccomp_test.go:19: statment ==> statement
    ./seccomp_test.go:140: nonexistant ==> nonexistent
    ./seccomp_test.go:363: nonexistant ==> nonexistent
    ./seccomp_test.go:366: nonexistant ==> nonexistent
    ./seccomp_test.go:423: correcly ==> correctly

  2. Add a CI job to ensure that future PRs won't add typos (at least
    those that that are known to codespell).

NOTE: this is currently a draft pending #69 merge (as it also fixes a typo). Will rebase once merged.

1. Fix a few typos found by codespell:

./seccomp_internal.go:820: reponse ==> response
./seccomp.go:267: notication ==> notification
./seccomp_test.go:19: statment ==> statement
./seccomp_test.go:140: nonexistant ==> nonexistent
./seccomp_test.go:363: nonexistant ==> nonexistent
./seccomp_test.go:366: nonexistant ==> nonexistent
./seccomp_test.go:423: correcly ==> correctly

2. Add a CI job to ensure that future PRs won't add typos (at least
   those that that are known to codespell).

Signed-off-by: Kir Kolyshkin <[email protected]>
@pcmoore
Copy link
Member

pcmoore commented Sep 24, 2021

Looks good to me, thanks.

Acked-by: Paul Moore <[email protected]>

Copy link
Member

@drakenclimber drakenclimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll merge it.

@drakenclimber
Copy link
Member

Thanks, @kolyshkin. Merged in commit 4a0a385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants