Refactor ajaxGetImportTemplate to find instrument import templates in addons

[mikejmets]

Description of the issue/feature this PR addresses

Linked issue: #1348

Current behavior before PR

Custom instrument import templates defined in addons are not found

Desired behavior after PR is merged

Custom instrument import templates defined in addons are used correctly

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

[xispa]

Thanks @mikejmets!. One change regarding getAnalysisServicesDisplayList function

[xispa]

As far as I am concerned, this function is used by some instrument interfaces (e.g. Qubit, Symex XS, etc.) to know the analysis services to which the results have to be applied. With this change, the value of the display list becomes the UID of the service instead of the keyword, so the parsers will probably not work properly:

senaite.core/bika/lims/exportimport/instruments/sysmex/xs/i500.py

Lines 71 to 78 in 26efddb

	analysis = request.form.get('analysis_service', None)
	if analysis:
	# Get default result key
	defaultresult = request.form.get('default_result', None)
	# Rise an error if default result is missing.
	parser = SysmexXS500iCSVParser(infile, analysis, defaultresult) if defaultresult \
	else errors.append(t(_("You should introduce a default result key.",
	mapping={"fileformat": fileformat})))

Setup catalog has getKeyword metadata, so I think the following would be fine:

items = map(lambda item: (item.getKeyword, item.Title), brains)

[mikejmets]

The change I made here was purely flake8 cosmetics, the previous version also returned UID and Title.

[xispa]

Hi @mikejmets , apologies for my slow reply. I've been out for two weeks.
Ummm... don't think so. Note the "ugly" previous implementation was using getObject().Keyword:

items = [('', '')] + [(o.getObject().Keyword, o.Title) for o in
                                bsc(portal_type = 'AnalysisService',
                                    is_active = True)]

while your implementation uses item.UID:

items.append((item.UID, item.Title))

[mikejmets]

My bad, changed it to use getKeyword.

[xispa]

Yes, indeed. Not fancy to have senaite/instruments hard-coded here. But since (correct me if I am wrong), the plan is to move all these instrument interfaces to senaite.instruments, then we can consider this as a "temporary" thingy until all them get ported.

[mikejmets]

I @xispa, I created a method to better determine is the instrument import interface is in or out of core. See latest commit

[xispa]

Just added a comment re getAnalysisServicesDisplayList. The rest seems fine to me!

[xispa]

Hi @mikejmets , apologies for my slow reply. I've been out for two weeks.
Ummm... don't think so. Note the "ugly" previous implementation was using getObject().Keyword:

items = [('', '')] + [(o.getObject().Keyword, o.Title) for o in
                                bsc(portal_type = 'AnalysisService',
                                    is_active = True)]

while your implementation uses item.UID:

items.append((item.UID, item.Title))