Remove senaite.instruments dependency for instrument import form
#1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Request removes the dependency of
senaite.instrumentsfor when an instrument interface is added in another add-on. See the linked issue for further details.@mikejmets , I've undone some of the changes you did in #1349 . Better use a named adapter or similar to handle templates from
senaite.instrumentsrather than forcing the user to manually installsenaite.instrumentsadd-on to make their own to work. This said, I think that at some point, the wholedataimport.pyand machinery behind (including the import form rendering through ajax) should be revisited/refactored.Linked issue: #1415
Current behavior before PR
Error when adding an instrument import interface in a custom add-on if
senaite.instrumentsis not installed.Desired behavior after PR is merged
No error when adding an instrument import interface in a custom add-on.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.