Filter Templates field when Sample Type is selected in Sample Add form #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user selects a SampleType in Add Sample Form, Templates that have a Sample Type assigned, but not the same as the one selected, are not displayed for selection. This commit also includes some clean-up of indexes and metadata that are no longer used.
ramonski
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
When a Sample Type is selected in Add Sample form, the Template field is not filtered by Sample Type. This Pull Request provides this functionality, but it also comes with some code redux for indexes and metadata related with SampleType.
ISampleTypeAwareMixinis also provided.Linked issue: #968
Current behavior before PR
Sample Templates field is not filtered when a Sample Type is selected
Desired behavior after PR is merged
Sample Templates field is filtered when a Sample Type is selected
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.