Removed stale type registrations #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
requested changes
Feb 12, 2020
There was a problem hiding this comment.
RejectAnalysis is used when a Worksheet is rejected. Haven't gone into details, but for what I've seen, when a Worksheet is rejected, an object of type RejectAnalysis for each routine analysis is created in same slot, while the counterpart original analysis is moved to a new worksheet. I think this is used to prevent worksheets to end-up being empty while keeping the original analyses without changes:
https://github.com/senaite/senaite.core/blob/master/bika/lims/content/worksheet.py#L1414
|
Sorry, I missed that place where it was used. Just ressurected it |
I understand, that place really hurts... |
xispa
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Remove the following stale types and their content code:
Current behavior before PR
Stale types in Database and Code
Desired behavior after PR is merged
Stale types are history
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.