Remove sampling rounds from core #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traceback (innermost last): Module ZPublisher.Publish, line 138, in publish Module ZPublisher.mapply, line 77, in mapply Module ZPublisher.Publish, line 48, in call_object Module Products.GenericSetup.tool, line 1053, in manage_doUpgrades Module Products.GenericSetup.upgrade, line 166, in doStep Module bika.lims.upgrade, line 68, in wrap_func_args Module bika.lims.upgrade.v01_03_003, line 393, in upgrade Module bika.lims.upgrade.v01_03_003, line 892, in remove_samplingrounds UnboundLocalError: local variable 'obj' referenced before assignment
Traceback (innermost last): Module ZPublisher.Publish, line 138, in publish Module ZPublisher.mapply, line 77, in mapply Module ZPublisher.Publish, line 48, in call_object Module Products.GenericSetup.tool, line 1053, in manage_doUpgrades Module Products.GenericSetup.upgrade, line 166, in doStep Module bika.lims.upgrade, line 68, in wrap_func_args Module bika.lims.upgrade.v01_03_003, line 393, in upgrade Module bika.lims.upgrade.v01_03_003, line 892, in remove_samplingrounds Module bika.lims.api, line 554, in get_path Module bika.lims.api, line 240, in get_object Module bika.lims.api, line 207, in fail APIError: <persistent broken bika.lims.controlpanel.bika_srtemplates.SRTemplates instance '\x00\x00\x00\x00\x00\x00\x1a\xdb'> is not supported.
xispa
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR removes the whole Sampling Rounds functionality from core, including the types
SamplingRound,SamplingRounds,SRTemplateandSRTemplates.Please merge #1530 first.
Current behavior before PR
Dysfunctional Sampling Rounds functionality in Core
Desired behavior after PR is merged
Completely removed Sampling Rounds from Core
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.