Add ProfileKey to AnalysisProfiles table #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
requested changes
Apr 26, 2022
| @@ -122,6 +122,7 @@ def folderitem(self, obj, item, index): | |||
|
|
|||
| item["replace"]["Title"] = get_link(url, value=title) | |||
| item["Description"] = description | |||
| item["ProfileKey"] = obj.ProfileKey | |||
There was a problem hiding this comment.
please use the object getter instead of accessing the attribute directly.
=> obj.getProfileKey()
There was a problem hiding this comment.
Sorry, my bad. Corrected
xispa
added a commit
that referenced
this pull request
Jul 14, 2022
ramonski
added a commit
that referenced
this pull request
Jul 14, 2022
Co-authored-by: Ramon Bartl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microfix
Description of the issue/feature this PR addresses
ProfileKey does not appear in the Profiles table
Linked issue: https://github.com/senaite/senaite.core/issues/
Current behavior before PR
No profile key
Desired behavior after PR is merged
ProfileKey shown
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.