Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProfileKey to AnalysisProfiles table #1987

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Add ProfileKey to AnalysisProfiles table #1987

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c001b7
Add ProfileKey to AnalysisProfiles table
toropok Apr 26, 2022
fb92948
Update CHANGES.rst
toropok Apr 26, 2022
a77c4dd
Update bika_analysisprofiles.py
toropok Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Changelog
2.2.0 (unreleased)
------------------

- #1987 Fix: ProfileKey shown in Profiles table
- #1981 Support for interim fields with empty values
- #1979 Multiselect/Multichoice support for interim fields
- #1980 Fix: Absent value for Unit field causes error
Expand Down
1 change: 1 addition & 0 deletions src/bika/lims/controlpanel/bika_analysisprofiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ def folderitem(self, obj, item, index):

item["replace"]["Title"] = get_link(url, value=title)
item["Description"] = description
item["ProfileKey"] = obj.ProfileKey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the object getter instead of accessing the attribute directly.

=> obj.getProfileKey()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad. Corrected


return item

Expand Down